Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: AmazonSQS connector should support DefaultAWSCredentialsProviderChain #44

Closed
nsn opened this issue May 3, 2022 · 5 comments
Assignees
Labels
Status: Accepted Confirmed defect or accepted improvement to implement, issue has been escalated to Platform Dev Type: Enhancement Label issue as an enhancement request

Comments

@nsn
Copy link

nsn commented May 3, 2022

Description


AmazonSQSActivationSpec should support DefaultAWSCredentialsProviderChain, either by providing a dedicated @ActionvationConfigProperty or just by default:

return new DefaultAWSCredentialsProviderChain().getCredentials();

Expected Outcome

The default credentials chain should be accessible for users

Current Outcome

only env vras and hard-coded string literals are supported, which makes it difficult to manage credentials securely

Context

All AWS SDKs support chaining of credential providers, by default checking for env vars, ~/.aws files and when deployed in Amazon containers obtaining credentials from the network. Since the AmazonSQS adapter needs to be deployed as a .rar it's impossible to implement not-yet-supported credentials providers, so support for default scheme can only be implemented in the library itself. This would take the burden of managing different secrets for different environments securely from the users.

Ecosystem Tool

Cloud Connectors

@nsn nsn added the Type: Enhancement Label issue as an enhancement request label May 3, 2022
@smillidge
Copy link

We have a PR for this payara/Cloud-Connectors#379 so plan to provide something based on the PR soon.

@JamesHillyard JamesHillyard self-assigned this Jul 27, 2022
@JamesHillyard
Copy link
Member

Hi @nsn,

As Steve has said, there is currently a community contribution which we believe will implement the functionality you are requesting. When there is an update regarding this contribution, I will inform you.

Thanks,
James

@smillidge
Copy link

This was fixed by payara/Cloud-Connectors#539

@JamesHillyard
Copy link
Member

Hi @nsn,

As Steve recently said, there has been a PR to fix this. This PR will be included in the Cloud Connectors 0.8.0, which will be released soon. I will again update you when Cloud Connectors 0.8.0 is available.

Thanks,
James

@JamesHillyard JamesHillyard added the Status: Accepted Confirmed defect or accepted improvement to implement, issue has been escalated to Platform Dev label Aug 23, 2022
@JamesHillyard
Copy link
Member

Hi @nsn,

Cloud Connectors 0.8.0 has now been released and contains your suggested enhancement implemented in the PR mentioned by Steve, payara/Cloud-Connectors#539.

Thanks,
James

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Accepted Confirmed defect or accepted improvement to implement, issue has been escalated to Platform Dev Type: Enhancement Label issue as an enhancement request
Projects
None yet
Development

No branches or pull requests

3 participants