Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Escrow #48

Merged
merged 9 commits into from
Oct 14, 2024
Merged

Escrow #48

merged 9 commits into from
Oct 14, 2024

Conversation

OnahProsperity
Copy link
Collaborator

@OnahProsperity OnahProsperity commented Sep 22, 2024 •
edited
Loading

  • Added tests to verify successful escrow of assets from provider to sender.
  • Added tests to ensure order cannot be processed more than once.
  • Added tests to check for invalid signatures.
  • Added tests to verify provider's balance sufficiency.
  • Added tests to handle zero address for provider and sender.
  • Added tests to calculate and transfer protocol fees correctly.
  • Added tests to ensure only aggregator can call escrow function.
  • Added tests to handle zero amount escrow."

closes #46

@OnahProsperity OnahProsperity self-assigned this Sep 22, 2024
@OnahProsperity OnahProsperity added the deployment Deployment task label Sep 22, 2024
chibie
chibie requested changes Oct 1, 2024
View reviewed changes
contracts/Gateway.sol Outdated Show resolved Hide resolved
contracts/Gateway.sol Outdated Show resolved Hide resolved
contracts/Gateway.sol Outdated Show resolved Hide resolved
@chibie chibie merged commit e61d1b3 into v1 Oct 14, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chibie chibie chibie requested changes

Assignees

@OnahProsperity OnahProsperity

Labels
deployment Deployment task
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@OnahProsperity @chibie