Signal keyconfig problem #153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Respond with `application/problem+json` when OHTTP decapsulation fails according to draft-ietf-ohai-ohttp section 5.3. See: https://ietf-wg-ohai.github.io/oblivious-http/draft-ietf-ohai-ohttp.html#section-5.3
Show response details including the body so that rejected key errors are clear.
DanGould
force-pushed
the
signal-keyconfig-problem
branch
from
47c0482 to
9e43b90
Compare
jbesraa
approved these changes
Dec 28, 2023
| @@ -218,6 +221,15 @@ impl HandlerError { | |||
| error!("Internal server error: {}", e); | |||
| *res.status_mut() = StatusCode::INTERNAL_SERVER_ERROR | |||
| } | |||
| HandlerError::OhttpKeyRejection(e) => { | |||
| const OHTTP_KEY_REJECTION_RES_JSON: &str = r#"{"type":"https://iana.org/assignments/http-problem-types#ohttp-key", "title": "key identifier unknown"}"#; | |||
There was a problem hiding this comment.
i think the title is a bit opaque, maybe its worth mentioning the specific problematic param ie ohttp_config
edit:
I see this is following the spec, but still we might want to add a message or something
There was a problem hiding this comment.
I agree, it would be instructive to show something like "Key identifier unknown. Refresh your payjoin directory configuration at $OHTTP_GATEWAY/ohttp-config" or similar.
I think this is a separate task for payjoin-cli, and eventually an implementation library doing I/O. Fortunately the client should be able to automate this problem away with automatic ip protected fetch as described here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #152
Signal OHTTP Key Configuration problem
Respond with
application/problem+jsonwhen OHTTP decapsulation failsaccording to draft-ietf-ohai-ohttp section 5.3. See:
https://ietf-wg-ohai.github.io/oblivious-http/draft-ietf-ohai-ohttp.html#section-5.3
Ensure the error response is clearly understood in payjoin-cli