Getting error "TypeError: fields is not iterable" while running generate:importmap Found a fix! Is it a proper fix ?

[geminigeek]

hi,
i have a complex setup with custom payload.config path, custom .env paths while running generate:importmap i am getting this error

<REDACTED>node_modules/.pnpm/[email protected][email protected][email protected][email protected][email protected][email protected][email protected]/node_modules/payload/src/bin/generateImportMap/iterateFields.ts:45
      genImportMapIterateFields({
      ^


TypeError: fields is not iterable
    at addToImportMap (<REDACTED>node_modules/.pnpm/[email protected][email protected][email protected][email protected][email protected][email protected][email protected]/node_modules/payload/src/bin/generateImportMap/iterateFields.ts:45:7)
    at genImportMapIterateFields (<REDACTED>node_modules/.pnpm/[email protected][email protected][email protected][email protected][email protected][email protected][email protected]/node_modules/payload/src/bin/generateImportMap/iterateFields.ts:46:9)
    at Object.generateImportMap (<REDACTED>node_modules/.pnpm/@[email protected]_smriuccx2dsmn7yjff5bhsip5e/node_modules/@payloadcms/richtext-lexical/src/utilities/generateImportMap.tsx:48:13)
    at genImportMapIterateFields (<REDACTED>node_modules/.pnpm/[email protected][email protected][email protected][email protected][email protected][email protected][email protected]/node_modules/payload/src/bin/generateImportMap/iterateFields.ts:80:20)
    at iterateCollections (<REDACTED>node_modules/.pnpm/[email protected][email protected][email protected][email protected][email protected][email protected][email protected]/node_modules/payload/src/bin/generateImportMap/iterateCollections.ts:23:5)
    at iterateConfig (<REDACTED>node_modules/.pnpm/[email protected][email protected][email protected][email protected][email protected][email protected][email protected]/node_modules/payload/src/bin/generateImportMap/iterateConfig.ts:22:3)
    at generateImportMap (<REDACTED>node_modules/.pnpm/[email protected][email protected][email protected][email protected][email protected][email protected][email protected]/node_modules/payload/src/bin/generateImportMap/index.ts:176:17)
    at bin (<REDACTED>node_modules/.pnpm/[email protected][email protected][email protected][email protected][email protected][email protected][email protected]/node_modules/payload/dist/bin/index.js:83:16)
    at async start (file://<REDACTED>node_modules/.pnpm/[email protected][email protected][email protected][email protected][email protected][email protected][email protected]/node_modules/payload/bin.js:30:7)

Node.js v22.11.0

i fixed this by modifying this file

payload/packages/payload/src/bin/generateImportMap/iterateFields.ts

Lines 20 to 35 in 6901b26

	export function genImportMapIterateFields({
	addToImportMap,
	baseDir,
	config,
	fields,
	importMap,
	imports,
	}: {
	addToImportMap: AddToImportMap
	baseDir: string
	config: SanitizedConfig
	fields: Block[] | Field[] | Tab[]
	importMap: InternalImportMap
	imports: Imports
	}) {
	for (const field of fields) {

i just added a conditional return , is it right way to do ? here is my modified code , the error is gone and everything works , just want a feedback on this, if fields can be undefined we need to add this to the core code ?

.... rest of code

// FIX before line 35

if(!fields) return

for (const field of fields) {
.... rest of code

[DanRibbens]

That shouldn't be necessary. I'd like to know what is in your config that causes fields to not be an array here.

If you can narrow it down perhaps there is some extra sanitization or misconfiguration that should throw an error. Can you create a minimal reproduction?

[geminigeek]

hi dan,
thanks for your reply, i figured it out, my config is going through multiple functions, some where i had undefined key fields set on a radio field, that was causing it

closing this as its irrelevant , if some one comes here some time this was my erroneous config causing the issue

{
    name: 'linkType',
    type: 'radio',
    admin: { description: [Function: description] },
    defaultValue: 'custom',
    label: [Function: label],
    options: [ [Object] ],
    required: true,
    fields: undefined // <- this was the issue
  },