Skip to content
This repository has been archived by the owner on Jan 22, 2020. It is now read-only.

make the render root configurable #68

Closed
samsel opened this issue Jul 30, 2015 · 11 comments
Closed

make the render root configurable #68

samsel opened this issue Jul 30, 2015 · 11 comments

Comments

@samsel
Copy link
Contributor

samsel commented Jul 30, 2015

right now, react-engine assumes document as the root element.
Need to make this configurable.

React.render(viewFactory(props), _document);

@dglozic
Copy link

dglozic commented Oct 17, 2015

+1 I just realized that it would help issue #73. We can render the envelope of the page on the server, and then mount the react component on a DIV inside the body element. We can render the edge elements of the page on the server only, while the parts of the page that are dynamic can be happening inside that root DIV where we mounted the component.

@samsel
Copy link
Contributor Author

samsel commented Oct 17, 2015

@slkuo230 has already completed this. @slkuo230 can you please rebase #69 so that we can merge it?

@slkuo230
Copy link

@samsel done!

@dglozic
Copy link

dglozic commented Oct 29, 2015

I was hoping v2.5.0 had this one but no luck. When do you plan to merge it into master?

@dglozic
Copy link

dglozic commented Nov 6, 2015

Bump - what does 'done' in the comment above refer to?

@slkuo230
Copy link

slkuo230 commented Nov 6, 2015

@dglozic it was referred to this PR #69. :)

@dglozic
Copy link

dglozic commented Nov 6, 2015

Damn :-). Any love for this issue? It would help us immensely. I can see @samsel opened this issue, so he must have had a use for it too.

It could be either an id for the mount node in 'options', or you can leave the DOM lookup part to the consumer and accept the DOM node in options to mount to. Either way, it should not be hard to add.

@samsel
Copy link
Contributor Author

samsel commented Nov 6, 2015

@slkuo230 @dglozic published this as v2.6.0. let me know :)

@samsel samsel closed this as completed Nov 6, 2015
@dglozic
Copy link

dglozic commented Nov 7, 2015

Hmmm.... I don't see v2.6.0- I only see tags up to v2.5.0.

@samsel
Copy link
Contributor Author

samsel commented Nov 8, 2015

its published to the repository already. You can just do npm install to get 2.6

@dglozic
Copy link

dglozic commented Nov 8, 2015

It was just a split second - I can now see v2.6 - thanks! We jump on it right away.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants