-
Notifications
You must be signed in to change notification settings - Fork 130
make the render root configurable #68
Comments
+1 I just realized that it would help issue #73. We can render the envelope of the page on the server, and then mount the react component on a DIV inside the body element. We can render the edge elements of the page on the server only, while the parts of the page that are dynamic can be happening inside that root DIV where we mounted the component. |
@samsel done! |
I was hoping v2.5.0 had this one but no luck. When do you plan to merge it into master? |
Bump - what does 'done' in the comment above refer to? |
Damn :-). Any love for this issue? It would help us immensely. I can see @samsel opened this issue, so he must have had a use for it too. It could be either an id for the mount node in 'options', or you can leave the DOM lookup part to the consumer and accept the DOM node in options to mount to. Either way, it should not be hard to add. |
Hmmm.... I don't see v2.6.0- I only see tags up to v2.5.0. |
its published to the repository already. You can just do |
It was just a split second - I can now see v2.6 - thanks! We jump on it right away. |
right now, react-engine assumes
document
as the root element.Need to make this configurable.
react-engine/lib/client.js
Line 69 in ecd27b3
The text was updated successfully, but these errors were encountered: