Skip to content

Commit

Permalink
Deprecate customizable width and height attributes
Browse files Browse the repository at this point in the history
  • Loading branch information
jhaemin committed May 14, 2020
1 parent 329208f commit 9fe6832
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 5 deletions.
1 change: 1 addition & 0 deletions src/components/global/icons/Magnifier.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ export const Magnifier: FillableIcon = ({ fill, size = 128, className }) => {
<>
<svg
className={className}
// TODO: inline width and height don't support CSS units like 'rem' or 'em'
width={size}
height={size}
viewBox="0 0 128 128"
Expand Down
6 changes: 1 addition & 5 deletions src/components/ui/LineInput/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -28,11 +28,7 @@ type LineInputProps = {
const IconField = React.memo(() => {
return (
<div className={$['magnifier-icon-wrapper']}>
<Magnifier
className={$['icon']}
fill={EodiroColors.primary}
size={'2rem'}
/>
<Magnifier className={$['icon']} fill={EodiroColors.primary} />
</div>
)
})
Expand Down

0 comments on commit 9fe6832

Please sign in to comment.