Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improved cli argument handling #32

Merged
merged 3 commits into from
Nov 19, 2024
Merged

Improved cli argument handling #32

merged 3 commits into from
Nov 19, 2024

Conversation

IBims1NicerTobi
Copy link
Collaborator

No description provided.

@IBims1NicerTobi IBims1NicerTobi linked an issue Nov 19, 2024 that may be closed by this pull request
Improve cli argument handling #31
Closed
VonTum
VonTum requested changes Nov 19, 2024
View reviewed changes
Copy link
Collaborator

@VonTum VonTum left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All in all I'm impressed with this change! You seem to have a strong grasp on the way clap 4 does things. Even a few test cases nicely round out this PR.

I've listed a few issues that still exist, but with those addressed I would happily merge.

src/config.rs Show resolved Hide resolved
src/config.rs Show resolved Hide resolved
src/config.rs Show resolved Hide resolved
@VonTum VonTum merged commit 9a97951 into master Nov 19, 2024
1 check passed
@IBims1NicerTobi IBims1NicerTobi deleted the 31-improve-cli-argument-handling branch November 19, 2024 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VonTum VonTum VonTum requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve cli argument handling
2 participants
@IBims1NicerTobi @VonTum