Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

getCometdURL argument mismatch #21

Open
moblizeit opened this issue Oct 5, 2020 · 2 comments
Open

getCometdURL argument mismatch #21

moblizeit opened this issue Oct 5, 2020 · 2 comments
Assignees

Comments

@moblizeit
Copy link

in cometd_setup the call is

var url = getCometdURL(data.conn, data.args);

whereas the signature has only one parameter as below:

function getCometdURL(conn:any) {
return conn.instanceUrl + '/cometd/44.0';
}

@pcon
Copy link
Owner

pcon commented Oct 5, 2020

Are you experiencing any issues because of that? Currently that method does not use any of the args and Javascript will just ignore any additional arguments passed. Because the args are not being used they were dropped from the method definition as to no have to add an eslint exception to the function declaration

@pcon pcon self-assigned this Oct 5, 2020
@moblizeit
Copy link
Author

well no issues just pointed as i use typescript and with tighter grammar rules it complains about it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants