Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PINN Baseline PDE #54

Open
2ailesB opened this issue Jan 16, 2024 · 2 comments
Open

PINN Baseline PDE #54

2ailesB opened this issue Jan 16, 2024 · 2 comments

Comments

@2ailesB
Copy link

2ailesB commented Jan 16, 2024

Hi,
I downloaded the dataset for the 1D Navier-Stokes Compressible Equation., and I have several questions about the PINN PDE that is implemented in pinn .

  • Why is the loss not corresponding to the equation provided in Appendix D5 ? Several terms are missing in the code, is there an explanation for that ? (In particular for the case where eta and zeta are 1e-1, these terms may have some influence ?).
  • What is the value of the viscous stress tensor ? How to fins the missing config to implement the complete PINN ?
  • I have noticed that there was a - before the pressure term in the second equation in the code, shouldn't it be a + ?

Thanks a lot for your help!

@LouisSerrano
Copy link

I have the same issue. It seems the implementation does not follow the equations from the paper, especially (16b). Maybe there is something that I am missing too. Could you provide an explanation for what has been implemented in pdebench/models/pinn/pde_definitions.py in the function pde_CFD1d ?

@lin01109
Copy link

lin01109 commented Jun 3, 2024

have the same issue here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants