Feedback #1
Open
Feedback #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-classroom[bot]](https://avatars.githubusercontent.com/in/68187?s=60&v=4){kind=small}
npasserini
reviewed
Dec 7, 2024
| class Persona { | ||
| var edad | ||
| var emociones = [] | ||
| var valorElevado |
| var emociones = [] | ||
| var valorElevado | ||
|
|
||
| method esAdolecente() = (edad >= 12) && (edad <= 19) |
| ) | ||
| } | ||
|
|
||
| method vivirEventoEnGrupo(grupo, unEvento) { |
There was a problem hiding this comment.
No es correcto que esto sea un método en una persona.
| } | ||
|
|
||
| class Emocion { | ||
| var intensidad = 0 |
There was a problem hiding this comment.
No es necesario dar valores iniciales a todos los atributos, 0 no es un buen valor por defecto acá.
| palabrotas.add(palabra) | ||
| } | ||
|
|
||
| method esIntensidadElevada() = intensidad > Persona.valorElevado |
| self.esIntensidadElevada() && palabrotas.any({ palabra => palabra.size() > 7 }) | ||
|
|
||
| override method liberarse(unEvento) { | ||
| if (self.puedeLiberarse()) { |
| intensidad = valor | ||
| } | ||
|
|
||
| override method puedeLiberarse() = intensidad > Persona.valorElevado && (eventosVividos % 2) == 0 |
| // Por parte de Herencia Ansiedad hereda atributos intensidad, eventosVividos y el metodo registrarEvento de Emocion. | ||
| // Sobrescribe metodos como puedeLiberarse y liberarse para implementar su propio comportamiento. | ||
|
|
||
| // Por parte del polimorfismo tenemos una clase base Emocion con metodos como puedeLiberarse y liberarse. |
There was a problem hiding this comment.
No explica correctamente el aprovechamiento de la herencia ni el polimorfismo.
|
|
||
| var grupo = [persona1, persona2] | ||
|
|
||
| persona1.vivirEventoEnGrupo(grupo, evento) |
There was a problem hiding this comment.
Falta modelar el grupo correctamente.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
👋! GitHub Classroom created this pull request as a place for your teacher to leave feedback on your work. It will update automatically. Don’t close or merge this pull request, unless you’re instructed to do so by your teacher.
In this pull request, your teacher can leave comments and feedback on your code. Click the Subscribe button to be notified if that happens.
Click the Files changed or Commits tab to see all of the changes pushed to the default branch since the assignment started. Your teacher can see this too.
Notes for teachers
Use this PR to leave feedback. Here are some tips:
For more information about this pull request, read “Leaving assignment feedback in GitHub”.
Subscribed: @MarcosSilva2001