Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Performance Issue] BlockAnylsis.StrictlyDominatesADominator() unoptimized #33

Open
Timocop opened this issue Jun 18, 2021 · 1 comment

Comments

@Timocop
Copy link

Timocop commented Jun 18, 2021

On large plugins it spends ~90% of the time comparing dominators inside BlockAnylsis.StrictlyDominatesADominator() and dominators() returning a whole array in a loop every time (which is ~60% of the time by itself). Which slows down the whole decompilation process.
Maybe using some kind of List or a property where you pass the index instead would speed it up.

Right now im profiling it using .NET Lysis, but should not be so different in Java i assume.
Because i have no idea how to profile Java 😅.
dnSpy_2021-06-18_13-54-17

Right now i don't have Eclipse installed to create a Pull request so i create an issue instead.

@Timocop
Copy link
Author

Timocop commented Jun 18, 2021

Seems like on Java this issue is no different (Used JProfiler).

jprofiler_2021-06-18_14-21-59

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant