Skip to content
This repository has been archived by the owner on Jun 7, 2022. It is now read-only.

Refactor peach-config to panic on error #25

Open
mhfowler opened this issue Feb 25, 2021 · 1 comment
Open

Refactor peach-config to panic on error #25

mhfowler opened this issue Feb 25, 2021 · 1 comment

Comments

@mhfowler
Copy link
Contributor

No description provided.

@mhfowler mhfowler self-assigned this Feb 25, 2021
@mhfowler
Copy link
Contributor Author

now that peach-config is also handling updating, perhaps panicing on any error isn't the best.

A more nuanced solution might be to pass a flag that says "panic_on_error=True" when building the image only,
so when we are building and image we panic on any error,
but in the Real World we try to keep going

for now though leaving this as is

@mhfowler mhfowler removed their assignment Mar 29, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant