forked from confluentinc/confluent-kafka-go
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bump to v1.9.1 #1
Open
denizsurmeli
wants to merge
30
commits into
master
Choose a base branch
from
bump-to-v1.9.0
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…olman, confluentinc#676) * Added convenience method StoreMessage that calls StoreOffsets * Added '.' at the end of the comment * Added Offset less than 0 check * Moved the check to the correct method Co-authored-by: Finn Colman <[email protected]>
…confluentinc#729) * Added MockCluster implementation which can be used for testing * adjust documentation for mock cluster * Added example for MockCluster * Fixed naming Co-authored-by: Magnus Edenhill <[email protected]> * fixed typo Co-authored-by: Magnus Edenhill <[email protected]> * removed Co-authored-by: Magnus Edenhill <[email protected]> * fixed comment Co-authored-by: Magnus Edenhill <[email protected]> * adjust documentation Co-authored-by: Magnus Edenhill <[email protected]> * adjustments regarding comments from Magnus * fixed cleanup code for kafka configuration * fixed destroy for C references * fixed spaces * removed call to `C.rd_kafka_conf_destroy(mc.cConf)` in close * added docu for MockCluster type * moved package statement into first line * adjustments according to @edenhill comments * Update kafka/mockcluster.go Co-authored-by: Magnus Edenhill <[email protected]> * removed duplicate import * removed the remark as suggested from @edelhill * changed typedef from struct_rd_kafka_mock_cluster_s to rd_kafka_mock_cluster_t Co-authored-by: Kristian Köhler <[email protected]> Co-authored-by: Magnus Edenhill <[email protected]> Co-authored-by: Kristian Köhler <[email protected]>
.. and remove Require: check from pc, will not work and is not needed.
The "package .." stanza needs to follow the package docs comment, but a previous commit moved the stanza to the top of the file which caused the package docs to be ignored by 'godoc'.
…close_queue API (confluentinc#800) authored-by: Jing Liu <[email protected]>
Bindings for ACL operations: CreateAcls DescribeAcls DeleteAcls
changed references to the new go.dev site or to github.com
improvements to client examples: - Changed the producer example to use the Events delivery channel. - Added another producer example using a custom delivery channel - Moved channel producer and consumer examples to the examples/legacy folder - Added missing descriptions for other examples - Consumer example with at-least-once guarantee by disabling enable.auto.offset.store and using StoreMessage - Custom channel example with a channel for each Produce call
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.