Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible Storage Bloating #18

Open
timurguvenkaya opened this issue Dec 7, 2023 · 0 comments
Open

Possible Storage Bloating #18

timurguvenkaya opened this issue Dec 7, 2023 · 0 comments

Comments

@timurguvenkaya
Copy link

Description

It was observed that ItemStore is unbounded, and add_item does not take any storage deposit. Anyone can bloat the storage, degrade the chain's performance, and make it more costly by adding a massive number of dummy items.

Recommendation

Put a sufficient storage deposit so that it won't be financially viable for a malicious actor to attempt such an attack. Also, add the delete_item function which will delete an item from storage and refund a storage deposit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant