Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated index.d.ts with createGroupOptions #3179

Open
wants to merge 41 commits into
base: main
Choose a base branch
from
Open

Updated index.d.ts with createGroupOptions #3179

wants to merge 41 commits into from

Conversation

rbkayz
Copy link

@rbkayz rbkayz commented Jul 3, 2024

PR Details

Updated index.d.ts with createGroupOptions (announce, restrict, memberAddMode and membershipApprovalMode)

Related Issue

Motivation and Context

If we don't add this, any group that's created is done with default options

How Has This Been Tested

Types of changes

  • Dependency change
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • I have updated the documentation accordingly (index.d.ts).

PurpShell and others added 30 commits March 14, 2024 11:15
@PurpShell
fix(webpack-exodus): Added the new patch
c1ae300
@PurpShell
fix(webpack-exodus): Fixed v2.3000.x and v2.24
db72385
@PurpShell
chore(webpack-exodus): eslint
24196db
@PurpShell
Merge branch 'main' into webpack-exodus
f001408
@PurpShell
fix(webpack-exodus): Fixed Store
eda1920
@PurpShell
Merge branch 'webpack-exodus' of https://github.com/pedroslopez/whats…
467f6d2 
…app-web.js into webpack-exodus
@PurpShell
fix(webpack-exodus): slight store fix
21904ef
@PurpShell
chore(webpack-exodus): fix example so that I don't crash on every load
5969892
@alechkos
chore: eslint fix
1df7e4f
@PurpShell
fix(webpack-exodus): prevent confusion with build systems
77f9c18
@PurpShell
Merge branch 'webpack-exodus' of https://github.com/pedroslopez/whats…
75623c8 
…app-web.js into webpack-exodus
@PurpShell
fix(webpack-exodus): Add proper groups module
5b1e911
@PurpShell
fix(webpack-exodus): Fix order queries
78dc055
@PurpShell
fix(webpack-exodus): Bad export name
269e44e
@PurpShell
feat(webpack-exodus): Re-injection, No more selectors, Pairing Code auth
85db3d2
@PurpShell
fix(webpack-exodus): Eslint and better login/logout handling
27621f1
@PurpShell
fix(webpack-exodus): 2.24 compatibility
dd75967
@PurpShell
revert testing options
e7ae65f
@PurpShell
chore(webpack-exodus): ESLint
cad33ec
@PurpShell
chore(webpack-exodus): final eslint tweak (did not commit with last c…
452b712 
…ommit for some reason)
@alechkos
Merge branch 'main' into webpack-exodus
b347aa6
@alechkos
style: fix broken link in readme file
fac0d81
@alechkos
Merge branch 'main' into webpack-exodus
53672d0
@PurpShell
fix(webpack-exodus): Fix forwarding messages
c1d8e04
@PurpShell
Merge branch 'webpack-exodus' of https://github.com/pedroslopez/whats…
86d5dc4 
…app-web.js into webpack-exodus
@PurpShell
fix(webpack-exodus): finish forwarding function
650cd0d
@tuyuribr
Making the ESLint god happy
64491be
@seowzhenjun0126 @alechkos
Fix window.Store.ProfilePic.profilePicFind is not a function error (p…
975819d 
…edroslopez#3001)

* Change window.Store.ProfilePic.profilePicFind to window.Store.ProfilePic.requestProfilePicFromServer

* Prevent breaking v2.2x

* refactor: make it more readable

---------

Co-authored-by: alechkos <[email protected]>
@tuyuribr
Sanitize, improves and fixes
e4c208c
@tuyuribr
make ESList god happy
252ed8f
themazim and others added 11 commits May 15, 2024 20:45
@themazim @sneumannws @alechkos
fix getInviteCode for group (pedroslopez#3007) (pedroslopez#3029)
2798396 
* fix getInviteCode for group (pedroslopez#3007)

* move changes to proper getInviteCode method.

* style fix

* refactor: add try-catch in a case the user is not a group admin

* refactor: handle promise properly

---------

Co-authored-by: Sven Neumann <[email protected]>
Co-authored-by: alechkos <[email protected]>
@tuyuribr
fixes
6df4eef
@tuyuribr
Update LocalWebCache.js
1ecdc42
@jrocha @alechkos
fix delete on 2.3000 (pedroslopez#3048)
96b4742 
* fix delete on 2.3000

* fix compareWwebVersions

* fix: use proper comparison operator

---------

Co-authored-by: alechkos <[email protected]>
@MatMercer
Implement bot invoking capabilities (pedroslopez#3009)
bbb8d18 
* Implement bot invoking capabilities

* Update index.d.ts

* Eslint
@jrocha
Webpack exodus fix message_reaction event (pedroslopez#3099)
752d9ae 
* exposed WAWebAddonReactionTableMode

* capture reaction using WAWebAddonReactionTableMode

* move compareWwebVersions and check version before trying to expose new store
@jrocha
message_reaction on example.js (pedroslopez#3102)
efc2bd0 
* handle message_reaction event on example.js

* log wweb version on ready
@jrocha
fix reactions on pvt chats (pedroslopez#3104)
cd566f2
@tuyuribr
New group function
4ddbb0d
@tuyuribr
new group settings
8034e8f
@rbkayz
Updated index.d.ts with createGroupOptions
783db3b
@rbkayz
Copy link
Author

rbkayz commented Jul 3, 2024

@tuyuribr @alechkos - updated types for createGroupOptions. Can you review and merge this please?

@rbkayz rbkayz mentioned this pull request Jul 3, 2024
Closed
6 tasks
@alechkos alechkos changed the base branch from webpack-exodus to main July 24, 2024 01:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sakth-star Sakth-star Sakth-star approved these changes

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@rbkayz @Sakth-star @PurpShell @alechkos @tuyuribr @seowzhenjun0126 @themazim @jrocha @MatMercer