This repository has been archived by the owner on Nov 22, 2017. It is now read-only.
DragView positions and Drag Limit #58
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please, can you tell me what is this pull request going to add to the repository? Is this a new feature or a fix? I'd like to have more information before to start reviewing your code. |
|
It's a new features. That's allow to minimize to left, center or right position. And change the drag limit. |
|
@pedrovgs Look to the line 676 on DraggableView class. I've change it (encapsulation), it can result a performance issue? If it can, I'll return to the original style. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DO NOT MERGE YET!
I'm fixing all yet, through Travis ...