From caec243c12bdf010971a4051731c1adccecfc763 Mon Sep 17 00:00:00 2001 From: Robert Pajak Date: Thu, 13 Feb 2025 22:24:14 +0100 Subject: [PATCH] Use the same logger for BenchmarkLoggerEmit and BenchmarkLoggerEnabled --- sdk/log/logger_bench_test.go | 17 ++++++++++------- 1 file changed, 10 insertions(+), 7 deletions(-) diff --git a/sdk/log/logger_bench_test.go b/sdk/log/logger_bench_test.go index 856536ba063..2afe8a3134c 100644 --- a/sdk/log/logger_bench_test.go +++ b/sdk/log/logger_bench_test.go @@ -11,11 +11,10 @@ import ( "github.com/stretchr/testify/require" "go.opentelemetry.io/otel/log" - "go.opentelemetry.io/otel/sdk/instrumentation" ) func BenchmarkLoggerEmit(b *testing.B) { - logger := newLogger(NewLoggerProvider(), instrumentation.Scope{}) + logger := newTestLogger(b) r := log.Record{} r.SetTimestamp(time.Date(2000, time.January, 1, 0, 0, 0, 0, time.UTC)) @@ -64,11 +63,7 @@ func BenchmarkLoggerEmit(b *testing.B) { } func BenchmarkLoggerEnabled(b *testing.B) { - provider := NewLoggerProvider( - WithProcessor(newFltrProcessor("0", false)), - WithProcessor(newFltrProcessor("1", true)), - ) - logger := provider.Logger(b.Name()) + logger := newTestLogger(b) ctx := context.Background() param := log.EnabledParameters{Severity: log.SeverityDebug} var enabled bool @@ -82,3 +77,11 @@ func BenchmarkLoggerEnabled(b *testing.B) { _ = enabled } + +func newTestLogger(t testing.TB) log.Logger { + provider := NewLoggerProvider( + WithProcessor(newFltrProcessor("0", false)), + WithProcessor(newFltrProcessor("1", true)), + ) + return provider.Logger(t.Name()) +}