Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

minValue not working as expceted #43

Closed
JFconcept opened this issue Jul 2, 2024 · 2 comments
Closed

minValue not working as expceted #43

JFconcept opened this issue Jul 2, 2024 · 2 comments

Comments

@JFconcept
Copy link

Describe the bug
Hi, the MinValueRule is not working as expceted, since it's checking for <= instead of <

Steps To Reproduce
The field

MoneyInput::make('budget')
->minValue(2500);

results in Error:
The Budget must be at least 25.00.

Screenshots
Bildschirmfoto 2024-07-02 um 14 39 09

Additional context
MinValueRule.php - line 28:
if ($minorValue <= $this->min) {
needs to be:
if ($minorValue < $this->min) {
@holmesadam
Copy link
Contributor

Pull request created here: #47

@pelmered
Copy link
Owner

Fixed in version 1.4.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@JFconcept @pelmered @holmesadam