Remove explicit file.close because QFile already handles this

pencil2d · Nov 29, 2024 · 685f96f · 685f96f
1 parent 85b43e6
commit 685f96f
Show file tree

Hide file tree

Showing 4 changed files with 0 additions and 23 deletions.
diff --git a/core_lib/src/graphics/vector/vectorimage.cpp b/core_lib/src/graphics/vector/vectorimage.cpp
@@ -83,9 +83,6 @@ bool VectorImage::read(QString filePath)
     {
         return false;
     }
-    ScopeGuard fileScope([&] {
-        file.close();
-    });
 
     QDomDocument doc;
     if (!doc.setContent(&file)) return false; // this is not a XML file
@@ -127,9 +124,6 @@ Status VectorImage::write(QString filePath, QString format)
         debugInfo << ("file.error() = " + file.errorString());
         return Status(Status::FAIL, debugInfo);
     }
-    ScopeGuard fileScope([&] {
-        file.close();
-    });
 
     if (format != "VEC")
     {

diff --git a/core_lib/src/soundplayer.cpp b/core_lib/src/soundplayer.cpp
@@ -42,10 +42,6 @@ void SoundPlayer::init(SoundClip* clip)
 
     QFile file(clip->fileName());
     file.open(QIODevice::ReadOnly);
-    ScopeGuard fileScope([&] {
-        file.close();
-    });
-
 
     mBuffer.setData(file.readAll());
     mBuffer.open(QBuffer::ReadOnly);

diff --git a/core_lib/src/structure/filemanager.cpp b/core_lib/src/structure/filemanager.cpp
@@ -114,9 +114,6 @@ Object* FileManager::load(const QString& sFileName)
         handleOpenProjectError(Status::ERROR_FILE_CANNOT_OPEN, dd);
         return nullptr;
     }
-    ScopeGuard fileScope([&] {
-        file.close();
-    });
 
     dd << "Main XML exists: Yes";
 
@@ -899,7 +896,6 @@ Status FileManager::recoverObject(Object* object)
         xmlDoc.setContent(&file);
         root = xmlDoc.documentElement();
         objectTag = root.firstChildElement("object");
-        file.close();
     }
     loadPalette(object);
 
@@ -937,9 +933,6 @@ Status FileManager::rebuildMainXML(Object* object)
     {
         return Status::ERROR_FILE_CANNOT_OPEN;
     }
-    ScopeGuard fileScope([&] {
-        file.close();
-    });
 
     QDomDocument xmlDoc("PencilDocument");
     QDomElement root = xmlDoc.createElement("document");

diff --git a/core_lib/src/structure/object.cpp b/core_lib/src/structure/object.cpp
@@ -519,9 +519,6 @@ bool Object::exportPalette(const QString& filePath) const
         qDebug("Error: cannot export palette");
         return false;
     }
-    ScopeGuard fileScope([&] {
-        file.close();
-    });
 
     if (file.fileName().endsWith(".gpl", Qt::CaseInsensitive))
         exportPaletteGPL(file);
@@ -667,9 +664,6 @@ bool Object::importPalette(const QString& filePath)
     {
         return false;
     }
-    ScopeGuard fileScope([&] {
-        file.close();
-    });
 
     if (file.fileName().endsWith(".gpl", Qt::CaseInsensitive))
     {