Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not make a new keyframe if double clicking on an existing keyframe #1851

Merged
merged 2 commits into from
Jul 20, 2024

Conversation

khoidauminh
Copy link
Contributor

Based on the message from the Software's discord server, quoted:

Not sure if it's been discussed here but:
First, double clicking in anywhere in the timeline gives you a new keyframe. Double clicking on a keyframe appends one after it.
When you need to move a keyframe, you need to click on it first before you can drag it around. If I happen to do this too fast, pencil2d registers this as a double click and does the keyframe appending. This can be annoying

I think it'll help a lot if pencil2d distinguishes between double clicking on an empty space and on a keyframe

This PR does exactly what the message above wants to. When double clicking on an existing keyframe, the program won't make a new keyframe, instead only selects it. Beneficial for those who want to drag the keyframe around in a quick way.

@MrStevns
Copy link
Member

Hi khoidauminh, thanks for the PR.

I implemented this feature with the goal that it should be easier to add addition frames to a Keyframe without having to move the existing ones on the timeline. From the thread though I realize that in its current state, the functionality is too easy to trigger.

Based on the feedback from Discord, I'll accept the PR for now.

@MrStevns
Copy link
Member

A made a small change to account for soundclip length and also put the scrub call inside the branch.
Will merge PR now.

@MrStevns MrStevns merged commit bfe2349 into pencil2d:master Jul 20, 2024
9 of 10 checks passed
@khoidauminh khoidauminh deleted the double-click-adjust branch July 21, 2024 01:30
@J5lx J5lx added UX Related to the way users interact with the program Timeline labels Jul 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Timeline UX Related to the way users interact with the program
Projects
Development

Successfully merging this pull request may close these issues.

3 participants