Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Memo login fails when using more than 1 connected account. #318

Open
gianfra-t opened this issue Dec 9, 2024 · 1 comment
Open

Memo login fails when using more than 1 connected account. #318

gianfra-t opened this issue Dec 9, 2024 · 1 comment
Labels
type:bug Something isn't working

Comments

@gianfra-t
Copy link
Contributor

Description and steps to replicate:

If we sign a message for Anclap once with account A, we switch to account B also signing the message and then try going back to A, we find that the offramp will not start for A with a memo error replied from the backend.

Why this is happening

After we moved to http-only cookie authentication, the backend sets it upon response of a successful login. This means that if there was an auth cookie before, it will be overridden.
As we also save a storage element that the UI uses to recognize that the cookie was set, and handle the expiration, when we switch back to account A on the scenario above, we end up sending the wrong cookie to the backed (that of account B).

Potential solutions

  • The quickest solution is to remove the storage of the old address entry after a new address has just signed. But this will mean that switching back to an account will require signing again.
  • If we want to avoid signing again, another option is to modify the name of the auth cookie such that it is unique for each address.
    We can then send all of them (which will be done automatically) and the backend needs to filter which one, if any, is valid.
@gianfra-t gianfra-t added the type:bug Something isn't working label Dec 9, 2024
@gianfra-t
Copy link
Contributor Author

@pendulum-chain/product This issue is not necessarily something urgent, but needs to be fixed soon. I don't think it is so uncommon that a user off-ramps from 2 wallets many times.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant