Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to Circle EUR.s deployment of Forex AMM for current Vortex version #98

Closed
3 tasks done
prayagd opened this issue Aug 13, 2024 · 13 comments · Fixed by #131
Closed
3 tasks done

Switch to Circle EUR.s deployment of Forex AMM for current Vortex version #98

prayagd opened this issue Aug 13, 2024 · 13 comments · Fixed by #131
Assignees

Comments

@prayagd
Copy link
Collaborator

prayagd commented Aug 13, 2024

Context

Currently vortex uses MYKOBO EUR.s in the backend which is to be demised, this ticket is to switch it to Circle EUR.s

Requirement

  • Replace MYKOBO EUR.s with Circle EUR.s in the Vortex backend
  • Set the anchor endpoint for Circle EURC using the toml file
  • Ideally check the issuer of the Stellar EURC used by the Nabla deployment to determine the anchor endpoint
@prayagd
Copy link
Collaborator Author

prayagd commented Aug 13, 2024

Hey team! Please add your planning poker estimate with Zenhub @ebma @gianfra-t @TorstenStueber @bogdanS98

@ebma
Copy link
Member

ebma commented Aug 13, 2024

If I understand correctly, we'd need to modify the existing Nabla deployment or deploy a new one. Modifying the existing one is probably better so we don't have to deposit all the liquidity again. However, I think we should withdraw all the deposited Mykobo EURC from the existing pool before removing it from the Nabla deployment. Or what do you think about how we should approach this @TorstenStueber?

@TorstenStueber
Copy link
Collaborator

There is already a Nabla deployment for USDC.axl and EURC Circle:

What is confusing is that we refer to the two Nabla instances on Pendulum as the "USDT" and the "USDC.axl" one. In fact,

  • the "USDT" instance uses EURC Mykobo and we added a USDC.axl pool to it later
  • the "USDC.axl" instance uses EURC Circle

So we just need to use the "USDC.axl" instance. You will see that currently all pools are empty and we need to fill them. Then we are good to go.

@prayagd
Copy link
Collaborator Author

prayagd commented Aug 27, 2024

@TorstenStueber can you please add your estimates?

@TorstenStueber
Copy link
Collaborator

@gianfra-t gianfra-t self-assigned this Sep 2, 2024
@gianfra-t
Copy link
Contributor

Mykobo does not yet support EURC circle, right? I am looking at their well-known/stellar.toml and it still points to the previous EURC.

So besides charging the pools, we need to wait for them to support this? Or is this file incorrect?

@ebma
Copy link
Member

ebma commented Sep 3, 2024

Good question, I never tried. But looking at the blog post, I assume that this feature is already live for some time now. @pendulum-chain/product can you confirm that withdrawing circle EURC with Mykobo is possible? Have you tried that before?

@gianfra-t
Copy link
Contributor

Because so far we only specify the asset code, then there is no way to differentiate between both. Since the offramp account has been the Mykobo EURC one, leads me to think that this is not supported, or at least some extra parameter has to be passed.

For instance, the optional asset_issuer allowed in the sep 24 specs.

@ebma
Copy link
Member

ebma commented Sep 3, 2024

Interesting, thanks for sharing. Maybe they support both assets and we can just send either Mykobo EURC or Circle EURC to their endpoint and the result is the same. Could be that they just forgot to update their Stellar.toml file.

Let's wait for a clarification from the product team and if no one tried this before we can reach out on Slack.

@gianfra-t
Copy link
Contributor

Moving to Icebox until we have clarification from Mykobo, or decide to test it anyway.

@vadaynujra
Copy link

MYKOBO has explicitly confirmed that they can off ramp Circle's EURC already. I will confirm why their .toml file doesn't already include it @gianfra-t @ebma

@vadaynujra
Copy link

For this ticket's pov, we can go ahead and test, taking my confirmation as final for now.

@gianfra-t
Copy link
Contributor

@pendulum-chain/product we can test a EURC.circle based off-ramp in this deployment.

@ebma ebma closed this as completed in #131 Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants