Fix inconstencies with all_requests and rename all_requests to all

backend/clubs/models.py

@@ -1077,7 +1077,7 @@ def __str__(self):
         return "<SearchQuery: {} at {}>".format(self.query, self.created_at)
 
 
-class Request(models.Model):
+class JoinRequest(models.Model):
     """
     Abstract base class for Membership Request and Ownership Request
     """
@@ -1097,7 +1097,7 @@ class Meta:
         unique_together = (("requester", "club"),)
 
 
-class MembershipRequest(Request):
+class MembershipRequest(JoinRequest):
     """
     Used when users are not in the club but request membership from the owner
     """
@@ -1128,7 +1128,7 @@ def send_request(self, request=None):
             )
 
 
-class OwnershipRequest(Request):
+class OwnershipRequest(JoinRequest):
     """
     Represents a user's request to take ownership of a club
     """

backend/clubs/views.py

@@ -3943,7 +3943,7 @@ class OwnershipRequestManagementViewSet(viewsets.ModelViewSet):
     accept:
     Accept an ownership request as a club owner.
 
-    old_requests:
+    all:
     Return a list of ownership requests older than a week. Used by Superusers.
     """
 
@@ -3954,7 +3954,7 @@ class OwnershipRequestManagementViewSet(viewsets.ModelViewSet):
     lookup_field = "requester__username"
 
     def get_queryset(self):
-        if self.action != "all_requests":
+        if self.action != "all":
             return OwnershipRequest.objects.filter(
                 club__code=self.kwargs["club_code"], withdrawn=False
             )
@@ -3997,7 +3997,7 @@ def accept(self, request, *args, **kwargs):
         return Response({"success": True})
 
     @action(detail=False, methods=["get"], permission_classes=[IsSuperuser])
-    def all_requests(self, request, *args, **kwargs):
+    def all(self, request, *args, **kwargs):
         """
         View unaddressed ownership requests, sorted by date.
         ---