feat: add volume data #193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grod220
reviewed
Dec 9, 2024
There was a problem hiding this comment.
Nice job!
Two design points of feedback:
- Could we shorten the height a bit? Feels a bit too tall. Looking at something like this as reference.
- Could we dim the red/green color so it doesn't look like it's competing with the price candles?
It looks like there is another label on the right, can we get rid of this?
grod220
reviewed
Dec 9, 2024
vacekj
force-pushed
the
153-add-volume-profile-to-chart
branch
3 times, most recently
from
b6ae765 to
3b27ba8
Compare
|
Haven't tested the branch, but looking at the screenshot, the chart looks like the UM/USDC chart but the volume is listed as 19.5B, which doesn't seem right? |
vacekj
force-pushed
the
153-add-volume-profile-to-chart
branch
from
3b27ba8 to
89dfa7a
Compare
vacekj
force-pushed
the
153-add-volume-profile-to-chart
branch
from
6d7867a to
c0770fb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #153