Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated asset selector component #163

Closed
grod220 opened this issue Nov 25, 2024 · 0 comments · Fixed by #204
Closed

Updated asset selector component #163

grod220 opened this issue Nov 25, 2024 · 0 comments · Fixed by #204
Assignees
@VanishMax

Comments

@grod220
Copy link
Contributor

grod220 commented Nov 25, 2024

New pair-selected view. Has a star the save favorites (in local storage).
Screenshot 2024-11-22 at 4 57 26 PM

First screen in modal
Screenshot 2024-11-22 at 4 59 35 PM

Likely will need to add a new backend endpoint to get top X pairs by volume for suggested list.

Manual selecting pair screen.
Screenshot 2024-11-25 at 11 51 08 AM
Should be sorted by priority score. Recent searches from local storage. After selecting first asset, it should be removed from second asset list.

Able to search for individual assets:
Screenshot 2024-11-25 at 11 52 34 AM

Confirmation screen.
Screenshot 2024-11-25 at 11 53 26 AM

Figma reference: https://www.figma.com/design/xWsVprkEgEihweVN9isrGQ/DEX-(Incl.-UI-Lib)?node-id=3658-145100&node-type=canvas&t=MYKb27akVH0wi7kK-0
@github-project-automation github-project-automation bot moved this to 🗄️ Backlog in Penumbra web Nov 25, 2024
@grod220 grod220 moved this to 📝 Todo in Labs web Nov 25, 2024
@grod220 grod220 added this to Labs web Nov 25, 2024
@VanishMax VanishMax moved this from 📝 Todo to 🏗 In progress in Labs web Dec 6, 2024
@VanishMax VanishMax self-assigned this Dec 6, 2024
@VanishMax VanishMax mentioned this issue Dec 11, 2024
Merged
@grod220 grod220 mentioned this issue Dec 14, 2024
Closed
VanishMax added a commit that referenced this issue Dec 16, 2024
@VanishMax
Merge branch 'main' into feat/#163-asset-selector
ee230a2 
# Conflicts:
#	package.json
#	pnpm-lock.yaml
@grod220 grod220 mentioned this issue Dec 16, 2024
Closed
VanishMax added a commit that referenced this issue Dec 18, 2024
@VanishMax
Merge branch 'main' into feat/#163-asset-selector
a0f7496 
# Conflicts:
#	src/pages/trade/ui/pair-selector.tsx
VanishMax added a commit that referenced this issue Dec 19, 2024
@VanishMax
feat: #163: pair selector (#204)
8aad7da 
* fix: apply new UI changes of density

* feat: set up new PairSelector

* feat: add star-pair feature

* feat: implement basic pair selection

* refactor: create more components related to pair selector

* feat: implement filtering input

* feat: implement `/api/pairs` endpoint to fetch the most popular pairs

* feat: implement recent assets in search results

* feat: use balances in the search results

* fix: small bugs

* fix: merge

* fix: ts

* fix: handle the pr feedback
@github-project-automation github-project-automation bot moved this from 🗄️ Backlog to ✅ Done in Penumbra web Dec 19, 2024
@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in Labs web Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@VanishMax VanishMax

Labels
None yet
Projects
Penumbra web
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: #163: pair selector penumbra-zone/dex-explorer
2 participants
@grod220 @VanishMax