Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui package exports are complex #728

Closed
Tracked by #729
turbocrime opened this issue Mar 12, 2024 · 4 comments
Closed
Tracked by #729

ui package exports are complex #728

turbocrime opened this issue Mar 12, 2024 · 4 comments
Labels
refactor Improving existing system with new design

Comments

@turbocrime
Copy link
Contributor

No description provided.

@github-project-automation github-project-automation bot moved this to 🗄️ Backlog in Penumbra web Mar 13, 2024
@grod220 grod220 added the refactor Improving existing system with new design label Mar 21, 2024
@TalDerei
Copy link
Contributor

we've had a bunch of changes with package exports and publishing, is this still relevant?

@VanishMax
Copy link
Contributor

VanishMax commented Sep 2, 2024

the exports were simplified for v2, so users now import the components like this:

import { Button } from '@penumbra-zone/ui/Button';
import { Text } from '@penumbra-zone/ui/Text';

we still have to remove the v1 to not even include it in NPM but that might not be the scope if this issue. I'd close it

@TalDerei
Copy link
Contributor

TalDerei commented Sep 2, 2024

we still have to remove the v1 to not even include it in NPM but that might not be the scope if this issue. I'd close it

can you capture this in another issue and close this?

@VanishMax
Copy link
Contributor

Will be followed by #1754

@github-project-automation github-project-automation bot moved this from 🗄️ Backlog to ✅ Done in Penumbra web Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Improving existing system with new design
Projects
Archived in project
Development

No branches or pull requests

4 participants