Fix old looping samples not stopping when replacing a `SkinnableSound…

…`'s `Samples` Closes ppy#30365.
peppy · Oct 22, 2024 · 1008d32 · 1008d32
1 parent 53a3409
commit 1008d32
Showing 1 changed file with 3 additions and 0 deletions.
diff --git a/osu.Game/Skinning/SkinnableSound.cs b/osu.Game/Skinning/SkinnableSound.cs
@@ -154,6 +154,9 @@ private void updateSamples()
         {
             bool wasPlaying = IsPlaying;
 
+            if (wasPlaying && Looping)
+                Stop();
+
             // Remove all pooled samples (return them to the pool), and dispose the rest.
             samplesContainer.RemoveAll(s => s.IsInPool, false);
             samplesContainer.Clear();