Skip to content
This repository has been archived by the owner on Mar 4, 2024. It is now read-only.

EVEREST-496 Add target namespaces to backup storages #415

Conversation

recharte
Copy link
Collaborator

@recharte recharte commented Jan 31, 2024

EVEREST-496 Powered by Pull Request Badge

Add target namespaces to backup storages

NOTE FOR REVIEWERS: Still missing api-tests, there are other dependencies (e.g. monitoring part) that need to be sorted out. I'll submit a follow-up PR to address the integration tests once the dependencies are sorted out.

Problem:
EVEREST-496

As per the everest-operator BackupStorage spec, they should have the target namespaces field that dictates in which namespaces it's allowed to be used.

CHECKLIST

Jira

  • Is the Jira ticket created and referenced properly?

Tests

  • Is an Integration test/test case added for the new feature/change?
  • Are unit tests added where appropriate?

@recharte recharte force-pushed the EVEREST-496-multi-namespaces-backup-storage branch 2 times, most recently from de260d5 to ba52b36 Compare January 31, 2024 15:26
@recharte recharte force-pushed the EVEREST-496-multi-namespaces-backup-storage branch from ba52b36 to 59fee69 Compare January 31, 2024 16:13
@recharte recharte marked this pull request as ready for review February 1, 2024 20:27
@recharte recharte requested a review from a user February 1, 2024 20:27
api/validation.go Outdated Show resolved Hide resolved
api/backup_storage.go Show resolved Hide resolved
api/validation.go Outdated Show resolved Hide resolved
docs/spec/openapi.yml Show resolved Hide resolved
docs/spec/openapi.yml Show resolved Hide resolved
Copy link
Contributor

@oksana-grishchenko oksana-grishchenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, approving since there is nothing to add from my side to the Michal's review.

@recharte recharte requested a review from a user February 6, 2024 08:46
@recharte recharte merged commit 9152e62 into EVEREST-495-multi-namespaces Feb 6, 2024
5 of 6 checks passed
@recharte recharte deleted the EVEREST-496-multi-namespaces-backup-storage branch February 6, 2024 13:35
@recharte recharte mentioned this pull request Feb 7, 2024
3 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants