Skip to content
This repository has been archived by the owner on Mar 4, 2024. It is now read-only.

EVEREST-449 Set monitoring to false by default #164

Merged
merged 9 commits into from
Oct 9, 2023
Merged

EVEREST-449 Set monitoring to false by default #164

merged 9 commits into from
Oct 9, 2023

Conversation

gen1us2k
Copy link
Contributor

@gen1us2k gen1us2k commented Oct 6, 2023

CHANGE DESCRIPTION

Problem:
EVEREST-449

Short explanation of the problem.

Related pull requests

  • [link]

Cause:
Short explanation of the root cause of the issue if applicable.

Solution:
Short explanation of the solution we are providing with this PR.

CHECKLIST

Jira

  • Is the Jira ticket created and referenced properly?

Tests

  • Is an Integration test/test case added for the new feature/change?
  • Are unit tests added where appropriate?

gen1us2k and others added 9 commits September 21, 2023 20:27
@gen1us2k
EVEREST-107 Update catalogsource and install script
68b2fee
@gen1us2k
EVEREST-107 update install.sh
cf65c36
@gen1us2k
EVEREST-107 wait for everest to be ready
316df12
@gen1us2k
EVEREST-406 Increased timeout for installing operators (#152)
ea97202
@gen1us2k
EVEREST-203 Do not run registration for already registered k8s cluste…
6da6b55 
…rs (#151)

* EVEREST-203 Do not run registration for already registered k8s clusters

* EVEREST-203 Generated files

* EVEREST-203 Added integration test

* EVEREST-203 Fixed test

* EVEREST-203 fixed test

* EVEREST-203 Better deletion handling

* EVEREST-203 Shut up linter

* Update pkg/install/operators.go

Co-authored-by: Michal Kralik <[email protected]>

---------

Co-authored-by: Michal Kralik <[email protected]>
@gen1us2k
EVEREST-107 Updated links for the public release
c70683e
@gen1us2k
merge
7a403cf
@gen1us2k
EVEREST-449 Set monitoring to false by default
3c343ff
@gen1us2k
u
a475fdc
@gen1us2k gen1us2k marked this pull request as ready for review October 6, 2023 13:10
@gen1us2k gen1us2k requested a review from a user October 6, 2023 13:10
ghost
ghost approved these changes Oct 9, 2023
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good.
Monitoring has been enabled by default by design though. It was requested by someone, not sure who though.

@gen1us2k gen1us2k merged commit 4ba98ad into main Oct 9, 2023
4 of 8 checks passed
@gen1us2k gen1us2k deleted the EVEREST-449 branch October 9, 2023 11:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@oksana-grishchenko oksana-grishchenko oksana-grishchenko approved these changes

@recharte recharte Awaiting requested review from recharte recharte is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gen1us2k @oksana-grishchenko