Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

K8SPG-645 turn on sidecar containers for pgbouncer #968

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

nmarukovich
Copy link
Contributor

@nmarukovich nmarukovich commented Dec 2, 2024

K8SPG-645 Powered by Pull Request Badge

CHANGE DESCRIPTION

Problem:
Sidecar containers for pgbouncer don't work by default

Cause:
We need to turn on PGBouncerSidecars variable

Solution:
Turn on it.

CHECKLIST

Jira

  • Is the Jira ticket created and referenced properly?
  • Does the Jira ticket have the proper statuses for documentation (Needs Doc) and QA (Needs QA)?
  • Does the Jira ticket link to the proper milestone (Fix Version field)?

Tests

  • Is an E2E test/test case added for the new feature/change?
  • Are unit tests added where appropriate?

Config/Logging/Testability

  • Are all needed new/changed options added to default YAML files?
  • Are all needed new/changed options added to the Helm Chart?
  • Did we add proper logging messages for operator actions?
  • Did we ensure compatibility with the previous version or cluster upgrade process?
  • Does the change support oldest and newest supported PG version?
  • Does the change support oldest and newest supported Kubernetes version?

@nmarukovich
Copy link
Contributor Author

nmarukovich commented Dec 2, 2024

@egegunes @inelpandzic @pooknull I have a question here.
Is there any reason why we didn't turn on it by default before?
If yes, do we want to move it to cr option?
For instances it is turned on by default.
Crunchy suggested use env var

PGO_FEATURE_GATES="PGBouncerSidecars=true"

@hors
Copy link
Collaborator

hors commented Dec 2, 2024

@egegunes @inelpandzic @pooknull I have a question here. Is there any reason why we didn't turn on it by default before? If yes, do we want to move it to cr option? For instances it is turned on by default. Crunchy suggested use env var

PGO_FEATURE_GATES="PGBouncerSidecars=true"

@nmarukovich We need to have it by default.

@nmarukovich
Copy link
Contributor Author

@egegunes @inelpandzic @pooknull I have a question here. Is there any reason why we didn't turn on it by default before? If yes, do we want to move it to cr option? For instances it is turned on by default. Crunchy suggested use env var
PGO_FEATURE_GATES="PGBouncerSidecars=true"

@nmarukovich We need to have it by default.

So please approve in this case (=

pooknull
pooknull previously approved these changes Dec 3, 2024
cmd/postgres-operator/main.go Outdated Show resolved Hide resolved
@JNKPercona
Copy link
Collaborator

Test name Status
custom-extensions failure
custom-tls failure
demand-backup failure
finalizers failure
init-deploy failure
monitoring failure
one-pod failure
operator-self-healing failure
pitr failure
scaling failure
scheduled-backup failure
self-healing failure
start-from-backup failure
tablespaces failure
telemetry-transfer failure
upgrade-consistency failure
upgrade-minor passed
users failure
We run 18 out of 18

commit: da3f76a
image: perconalab/percona-postgresql-operator:PR-968-da3f76aef

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants