K8SPSMDB-958 fix mongos metrics (#1289)

* K8SPSMDB-958 fix mongos metrics * fix indents * fix monitoring test * add security context to the tests * fix serviceless test * add condition for operator version * add condition for operator version * Update pkg/apis/psmdb/v1/psmdb_defaults.go Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
percona · Aug 30, 2023 · 3d4ed9c · 3d4ed9c
1 parent 13d615a
commit 3d4ed9c
Show file tree

Hide file tree

Showing 12 changed files with 59 additions and 12 deletions.
diff --git a/e2e-tests/demand-backup-sharded/compare/statefulset_some-name-mongos-4-oc.yml b/e2e-tests/demand-backup-sharded/compare/statefulset_some-name-mongos-4-oc.yml
@@ -117,6 +117,8 @@ spec:
             successThreshold: 1
             timeoutSeconds: 1
           resources: {}
+          securityContext:
+            runAsNonRoot: true
           terminationMessagePath: /dev/termination-log
           terminationMessagePolicy: File
           volumeMounts:

diff --git a/e2e-tests/demand-backup-sharded/compare/statefulset_some-name-mongos-oc.yml b/e2e-tests/demand-backup-sharded/compare/statefulset_some-name-mongos-oc.yml
@@ -117,6 +117,8 @@ spec:
             successThreshold: 1
             timeoutSeconds: 1
           resources: {}
+          securityContext:
+            runAsNonRoot: true
           terminationMessagePath: /dev/termination-log
           terminationMessagePolicy: File
           volumeMounts:

diff --git a/e2e-tests/demand-backup-sharded/compare/statefulset_some-name-mongos-secret.yml b/e2e-tests/demand-backup-sharded/compare/statefulset_some-name-mongos-secret.yml
@@ -117,6 +117,9 @@ spec:
             successThreshold: 1
             timeoutSeconds: 1
           resources: {}
+          securityContext:
+            runAsNonRoot: true
+            runAsUser: 1001
           terminationMessagePath: /dev/termination-log
           terminationMessagePolicy: File
           volumeMounts:
@@ -166,7 +169,8 @@ spec:
       restartPolicy: Always
       runtimeClassName: container-rc
       schedulerName: default-scheduler
-      securityContext: {}
+      securityContext:
+        fsGroup: 1001
       terminationGracePeriodSeconds: 30
       volumes:
         - name: some-name-mongodb-keyfile

diff --git a/e2e-tests/demand-backup-sharded/compare/statefulset_some-name-mongos.yml b/e2e-tests/demand-backup-sharded/compare/statefulset_some-name-mongos.yml
@@ -117,6 +117,9 @@ spec:
             successThreshold: 1
             timeoutSeconds: 1
           resources: {}
+          securityContext:
+            runAsNonRoot: true
+            runAsUser: 1001
           terminationMessagePath: /dev/termination-log
           terminationMessagePolicy: File
           volumeMounts:
@@ -166,7 +169,8 @@ spec:
       restartPolicy: Always
       runtimeClassName: container-rc
       schedulerName: default-scheduler
-      securityContext: {}
+      securityContext:
+        fsGroup: 1001
       terminationGracePeriodSeconds: 30
       volumes:
         - name: some-name-mongodb-keyfile

diff --git a/e2e-tests/expose-sharded/compare/statefulset_some-name-mongos-4-oc.yml b/e2e-tests/expose-sharded/compare/statefulset_some-name-mongos-4-oc.yml
@@ -117,6 +117,8 @@ spec:
             successThreshold: 1
             timeoutSeconds: 1
           resources: {}
+          securityContext:
+            runAsNonRoot: true
           terminationMessagePath: /dev/termination-log
           terminationMessagePolicy: File
           volumeMounts:

diff --git a/e2e-tests/expose-sharded/compare/statefulset_some-name-mongos-oc.yml b/e2e-tests/expose-sharded/compare/statefulset_some-name-mongos-oc.yml
@@ -147,6 +147,8 @@ spec:
           imagePullPolicy: Always
           name: mongos-sidecar-1
           resources: {}
+          securityContext:
+            runAsNonRoot: true
           terminationMessagePath: /dev/termination-log
           terminationMessagePolicy: File
       dnsPolicy: ClusterFirst

diff --git a/e2e-tests/expose-sharded/compare/statefulset_some-name-mongos.yml b/e2e-tests/expose-sharded/compare/statefulset_some-name-mongos.yml
@@ -117,6 +117,9 @@ spec:
             successThreshold: 1
             timeoutSeconds: 1
           resources: {}
+          securityContext:
+            runAsNonRoot: true
+            runAsUser: 1001
           terminationMessagePath: /dev/termination-log
           terminationMessagePolicy: File
           volumeMounts:
@@ -166,7 +169,8 @@ spec:
       restartPolicy: Always
       runtimeClassName: container-rc
       schedulerName: default-scheduler
-      securityContext: {}
+      securityContext:
+        fsGroup: 1001
       terminationGracePeriodSeconds: 30
       volumes:
         - name: some-name-mongodb-keyfile

diff --git a/e2e-tests/monitoring-2-0/compare/statefulset_monitoring-mongos-oc.yml b/e2e-tests/monitoring-2-0/compare/statefulset_monitoring-mongos-oc.yml
@@ -123,6 +123,8 @@ spec:
             requests:
               cpu: 300m
               memory: 500M
+          securityContext:
+            runAsNonRoot: true
           terminationMessagePath: /dev/termination-log
           terminationMessagePolicy: File
           volumeMounts:

diff --git a/e2e-tests/monitoring-2-0/compare/statefulset_monitoring-mongos.yml b/e2e-tests/monitoring-2-0/compare/statefulset_monitoring-mongos.yml
@@ -123,6 +123,9 @@ spec:
             requests:
               cpu: 300m
               memory: 500M
+          securityContext:
+            runAsNonRoot: true
+            runAsUser: 1001
           terminationMessagePath: /dev/termination-log
           terminationMessagePolicy: File
           volumeMounts:
@@ -295,7 +298,8 @@ spec:
               name: bin
       restartPolicy: Always
       schedulerName: default-scheduler
-      securityContext: {}
+      securityContext:
+        fsGroup: 1001
       terminationGracePeriodSeconds: 30
       volumes:
         - name: monitoring-mongodb-keyfile

diff --git a/e2e-tests/pitr-sharded/compare/statefulset_some-name-mongos.yml b/e2e-tests/pitr-sharded/compare/statefulset_some-name-mongos.yml
@@ -116,6 +116,9 @@ spec:
             successThreshold: 1
             timeoutSeconds: 1
           resources: {}
+          securityContext:
+            runAsNonRoot: true
+            runAsUser: 1001
           terminationMessagePath: /dev/termination-log
           terminationMessagePolicy: File
           volumeMounts:
@@ -163,7 +166,8 @@ spec:
       restartPolicy: Always
       runtimeClassName: container-rc
       schedulerName: default-scheduler
-      securityContext: {}
+      securityContext:
+        fsGroup: 1001
       terminationGracePeriodSeconds: 30
       volumes:
         - name: some-name-mongodb-keyfile

diff --git a/e2e-tests/serviceless-external-nodes/run b/e2e-tests/serviceless-external-nodes/run
@@ -8,11 +8,8 @@ set -o xtrace
 test_dir=$(realpath "$(dirname "$0")")
 . "${test_dir}/../functions"
 
-if [[ ${IMAGE_MONGOD} == *"percona-server-mongodb-operator"* ]]; then
-	MONGO_VER=$(echo -n "${IMAGE_MONGOD}" | $sed -r 's/.*([0-9].[0-9])$/\1/')
-else
-	MONGO_VER=$(echo -n "${IMAGE_MONGOD}" | $sed -r 's/.*:([0-9]+\.[0-9]+).*$/\1/')
-fi
+FULL_VER=$(get_mongod_ver_from_image ${IMAGE_MONGOD})
+MONGO_VER=${FULL_VER:0:3}
 unset OPERATOR_NS
 
 desc "Create main cluster"
@@ -59,8 +56,8 @@ cat "${test_dir}/compare/rs.txt" \
 
 diff $tmp_dir/rs-expected.txt "$tmp_dir/rs.txt"
 
-destroy "$namespace" "true"
-
+kubectl_bin -n ${replica_namespace} delete psmdb/${cluster}
 destroy $replica_namespace "true"
+destroy $namespace "true"
 
 desc "test passed"
diff --git a/pkg/apis/psmdb/v1/psmdb_defaults.go b/pkg/apis/psmdb/v1/psmdb_defaults.go
@@ -143,7 +143,27 @@ func (cr *PerconaServerMongoDB) CheckNSetDefaults(platform version.Platform, log
 				cr.Spec.Sharding.Mongos.Size = minSafeMongosSize
 			}
 		}
+		if cr.CompareVersion("1.15.0") >= 0 {
+			var fsgroup *int64
+			if platform == version.PlatformKubernetes {
+				var tp int64 = 1001
+				fsgroup = &tp
+			}
+
+			if cr.Spec.Sharding.Mongos.ContainerSecurityContext == nil {
+				tvar := true
+				cr.Spec.Sharding.Mongos.ContainerSecurityContext = &corev1.SecurityContext{
+					RunAsNonRoot: &tvar,
+					RunAsUser:    fsgroup,
+				}
+			}
 
+			if cr.Spec.Sharding.Mongos.PodSecurityContext == nil {
+				cr.Spec.Sharding.Mongos.PodSecurityContext = &corev1.PodSecurityContext{
+					FSGroup: fsgroup,
+				}
+			}
+		}
 		cr.Spec.Sharding.ConfigsvrReplSet.Name = ConfigReplSetName
 
 		if cr.Spec.Sharding.Mongos.Port == 0 {