K8SPSMDB-807: Allow customizing replset name with custom config #1252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fix * fix sharding --------- Co-authored-by: Andrii Dema <[email protected]>
--------- Co-authored-by: Ege Güneş <[email protected]> Co-authored-by: Viacheslav Sarzhan <[email protected]>
nmarukovich
reviewed
Sep 8, 2023
| wait_backup_agent $cluster-shard7-0 | ||
| wait_backup_agent $cluster-shard7-1 | ||
| wait_backup_agent $cluster-shard7-2 | ||
| backup_name_aws="backup-aws-s3" |
There was a problem hiding this comment.
Why do we use only even shard numbers?
There was a problem hiding this comment.
the CR is from a customer environment, following their setup
There was a problem hiding this comment.
I remember it. Oks. Could we add comment about it?
There was a problem hiding this comment.
sure, what do you want to see in comment?
There was a problem hiding this comment.
As for me, It would be nice to add an explanation why we use this shards configuration
hors
requested changes
Sep 8, 2023
| endpointUrl: https://storage.googleapis.com | ||
| image: percona/percona-server-mongodb:4.4.10-11 | ||
| imagePullPolicy: Always | ||
| mongod: |
There was a problem hiding this comment.
@egegunes, we do not have mongod at all now. That is why you have a problem with this test.
e2e-tests/functions
Outdated
Comment on lines
10
to
13
| IMAGE_MONGOD_CHAIN=${IMAGE_MONGOD_CHAIN:-$' | ||
| perconalab/percona-server-mongodb-operator:main-mongod4.4 | ||
| perconalab/percona-server-mongodb-operator:main-mongod5.0 | ||
| perconalab/percona-server-mongodb-operator:main-mongod6.0'} |
There was a problem hiding this comment.
We use this var in mongod-major-upgrade test.
hors
requested changes
Sep 8, 2023
pkg/psmdb/mongos.go
Outdated
Comment on lines
240
to
242
|
|
||
| container.LivenessProbe.Exec.Command[0] = "/opt/percona/mongodb-healthcheck" | ||
| container.ReadinessProbe.Exec.Command[0] = "/opt/percona/mongodb-healthcheck" |
There was a problem hiding this comment.
I think it is better to add for >= 1.15.0
hors
approved these changes
Sep 11, 2023
commit: 5d9ea86 |
pooknull
approved these changes
Sep 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGE DESCRIPTION
Problem:
There are two problems:
cfg.Solution:
Implemented a solution to override replset name using custom configuration:
CHECKLIST
Jira
Needs Doc) and QA (Needs QA)?Tests
compare/*-oc.yml)?Config/Logging/Testability