K8SPSMDB-926: Implement PiTR for physical restores #1288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
egegunes
force-pushed
the
K8SPSMDB-926
branch
2 times, most recently
from
872b2da to
60d59ae
Compare
pull-request-size
bot
added
size/XL
pull-request-size
bot
added
size/XXL
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| desc 'test passed' | ||
| } | ||
|
|
||
| main |
There was a problem hiding this comment.
[shfmt] reported by reviewdog 🐶
Suggested change
| main | |
| main |
inelpandzic
reviewed
Aug 29, 2023
| @@ -26,6 +27,26 @@ import ( | |||
| "github.com/percona/percona-server-mongodb-operator/version" | |||
| ) | |||
|
|
|||
| // reconcilePhysicalRestore performs a physical restore of a Percona Server for MongoDB from a backup. | |||
| // The function: | |||
There was a problem hiding this comment.
Do we need this comment? Primarily this part of how the method does what it's supposed to do.
|
|
||
| /opt/percona/pbm-agent 2> ${log} & |
There was a problem hiding this comment.
[shfmt] reported by reviewdog 🐶
Suggested change
| /opt/percona/pbm-agent 2> ${log} & | |
| /opt/percona/pbm-agent 2>${log} & |
| /opt/percona/ps-entry.sh "$@" | ||
|
|
||
| echo "Physical restore in progress" | ||
|
|
||
| cat ${log} | ||
| sleep infinity |
There was a problem hiding this comment.
[shfmt] reported by reviewdog 🐶
Suggested change
| sleep infinity | |
| sleep infinity |
inelpandzic
previously approved these changes
Sep 5, 2023
inelpandzic
previously approved these changes
Sep 8, 2023
pooknull
previously approved these changes
Sep 8, 2023
hors
reviewed
Sep 8, 2023
hors
reviewed
Sep 8, 2023
commit: 1eab7ad |
hors
approved these changes
Sep 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGE DESCRIPTION
Problem:
PiTR with physical backups are not implemented.
Solution:
Implement PiTR using PBM v2.2.1. Note that to use PiTR with physical backups you need to use PBM v2.2.1 or above.
CHECKLIST
Jira
Needs Doc) and QA (Needs QA)?Tests
compare/*-oc.yml)?Config/Logging/Testability