-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
K8SPSMDB-929: Add replicaSet horizons #1293
Conversation
@spron-in please review the cr.yaml and let me know if you want to change the interface. |
a7c0581
to
636fb1b
Compare
horizons := make(map[string]string) | ||
for h, domain := range rs.Horizons[pod.Name] { | ||
d := domain | ||
if !strings.HasSuffix(d, ":27017") { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe use DefaultMongoDBPort
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would but its a int32 and I need to convert it to string and this place will be very messy.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This "horizons" feature should allow you to chose ports, and not force the exclusive use of port 27017.
636fb1b
to
36babff
Compare
36babff
to
da5e3e4
Compare
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
commit: f790869 |
CHANGE DESCRIPTION
Problem:
If cluster is exposed, mongo clients can't connect to ReplicaSet with
?replicaSet=<rsName>
.Cause:
mongod doesn't know about external addresses.
Solution:
We need to allow users to configure split-horizon DNS. We're adding a new field (
horizons
) toReplsetSpec
, and users will be able to configure horizons:which will turn into the following replica set configuration:
Limitations:
CHECKLIST
Jira
Needs Doc
) and QA (Needs QA
)?Tests
compare/*-oc.yml
)?Config/Logging/Testability