K8SPSMDB-1062: Setting appProtocol for service objects

[sorenmat]

CHANGE DESCRIPTION

Problem:
When running in Istio (perhaps other serice meshes) we need to set the appProtocol to mongo.
This is needed since mongo is a server first protocol, which breaks the mTLS protocol

Cause:

A mongo cluster is not able to form.

Solution:

Just adding mongo as an appProtocol see: https://kubernetes.io/docs/concepts/services-networking/service/#application-protocol

CHECKLIST

Jira

• Is the Jira ticket created and referenced properly?
• Does the Jira ticket have the proper statuses for documentation (Needs Doc) and QA (Needs QA)?
• Does the Jira ticket link to the proper milestone (Fix Version field)?

Tests

• Is an E2E test/test case added for the new feature/change?
• Are unit tests added where appropriate?
• Are OpenShift compare files changed for E2E tests (compare/*-oc.yml)?

Config/Logging/Testability

• Are all needed new/changed options added to default YAML files?
• Are the manifests (crd/bundle) regenerated if needed?
• Did we add proper logging messages for operator actions?
• Did we ensure compatibility with the previous version or cluster upgrade process?
• Does the change support oldest and newest supported MongoDB version?
• Does the change support oldest and newest supported Kubernetes version?

[CLAassistant]

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

[hors]

@sorenmat please check and fix tests

[egegunes]

@sorenmat ping

[sorenmat]

I'm on it... 👍🏼 sorry for the delay

[egegunes]

@sorenmat please ensure that you add this new field to every service controlled by the operator

[egegunes]

Hi @sorenmat! We're working on next PSMDB operator release and if you finish this PR in next 2 weeks we can include this.

[egegunes]

@sorenmat there's a ExternalService function, please add the app protocol there also

[egegunes]

@sorenmat ping

[sorenmat]

@egegunes I'm a little tied up right now, because of Kubecon, so it might take a bit longer :|

[egegunes]

@sorenmat if you can finish this next week, we can include it in v1.16.0

[egegunes]

please fix conflicts

[egegunes]

@sorenmat ping

[hors]

@sorenmat @egegunes if we want to include it in v1.16.0 psmdb operator release please finish this PR this week. Thanks.

[sorenmat]

are the tests flaky, not sure how my change would result in tls-issue-cert-manager failing?

[JNKPercona]

Test name	Status
arbiter	passed
balancer	passed
custom-replset-name	passed
cross-site-sharded	passed
data-at-rest-encryption	passed
data-sharded	passed
demand-backup	passed
demand-backup-eks-credentials	passed
demand-backup-physical	passed
demand-backup-physical-sharded	passed
demand-backup-sharded	failure
expose-sharded	passed
ignore-labels-annotations	passed
init-deploy	passed
finalizer	passed
ldap	passed
ldap-tls	passed
limits	passed
liveness	passed
mongod-major-upgrade	passed
mongod-major-upgrade-sharded	passed
monitoring-2-0	passed
multi-cluster-service	passed
non-voting	passed
one-pod	passed
operator-self-healing-chaos	passed
pitr	passed
pitr-sharded	passed
pitr-physical	passed
pvc-resize	passed
recover-no-primary	passed
rs-shard-migration	passed
scaling	passed
scheduled-backup	passed
security-context	passed
self-healing-chaos	passed
service-per-pod	passed
serviceless-external-nodes	passed
smart-update	passed
split-horizon	passed
storage	passed
tls-issue-cert-manager	passed
upgrade	passed
upgrade-consistency	failure
upgrade-consistency-sharded-tls	failure
upgrade-sharded	passed
users	passed
version-service	passed
We run 48 out of 48

commit: 7b414d1
image: perconalab/percona-server-mongodb-operator:PR-1393-7b414d13

[egegunes]

@sorenmat do you still want to merge this? if you want, you can fix conflicts and change crVersion checks to 1.19.0.

[egegunes]

@hors maybe we can take this over and include it in v1.19.0?