PMM-12448 Fix bug (#2437)

PMM-12375 trigger the build
percona · Sep 16, 2023 · 3e453b1 · 3e453b1
1 parent 8008009
commit 3e453b1
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/managed/services/preconditions.go b/managed/services/preconditions.go
@@ -117,7 +117,9 @@ func CheckArtifactOverlapping(q *reform.Querier, serviceID, locationID, folder s
 	}
 
 	for _, artifact := range artifacts {
-		if artifact.ServiceID != serviceID {
+		// We skip artifacts made on services that are no longer exists in PMM. However, in future we can improve this function
+		// by storing required information right in artifact model.
+		if artifact.ServiceID != "" && artifact.ServiceID != serviceID {
 			svc, err := models.FindServiceByID(q, artifact.ServiceID)
 			if err != nil {
 				return err