Skip to content

Commit

Permalink
Merge branch 'main' into v3
Browse files Browse the repository at this point in the history
  • Loading branch information
ademidoff committed Oct 30, 2024
2 parents 43cc6db + 3733c5f commit 7d2c4fd
Show file tree
Hide file tree
Showing 9 changed files with 55,746 additions and 87 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -169,7 +169,7 @@ jobs:

steps:
- name: Slack Notification
uses: rtCamp/[email protected].1
uses: rtCamp/[email protected].2

workflow_failure:
if: ${{ failure() }}
Expand All @@ -187,4 +187,4 @@ jobs:

steps:
- name: Slack Notification
uses: rtCamp/[email protected].1
uses: rtCamp/[email protected].2
3 changes: 1 addition & 2 deletions Makefile.include
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@


.PHONY: default init release gen test clean all
default: help

Expand Down Expand Up @@ -37,7 +36,7 @@ gen: clean ## Generate files
make format ## TODO: One formatting run is not enough, figure out why.
go install -v ./...

clean: ## Remove generated files
clean: ## Remove generated files
make -C api clean

gen-mocks:
Expand Down
9 changes: 6 additions & 3 deletions api/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,9 @@ gen: ## Generate PMM API
platform/v1/json/v1.json
../bin/swagger validate swagger/swagger.json

../bin/swagger-order --output=swagger/swagger.json swagger/swagger.json
# It looks like the order is already correct, so no need to run this
# TODO: check if swagger-order can be removed
# ../bin/swagger-order --output=swagger/swagger.json swagger/swagger.json

# generate API spec with all PMM Server APIs (omit agentlocal)
../bin/swagger mixin --output=swagger/swagger-dev.json \
Expand All @@ -77,7 +79,8 @@ gen: ## Generate PMM API

../bin/swagger validate swagger/swagger-dev.json

../bin/swagger-order --output=swagger/swagger-dev.json swagger/swagger-dev.json
# It looks like the order is already correct, so no need to run this
# ../bin/swagger-order --output=swagger/swagger-dev.json swagger/swagger-dev.json

format: ## Format API definitions
../bin/buf format . -w
Expand Down Expand Up @@ -124,4 +127,4 @@ clean: clean-swagger ## Remove generated files
rm -f swagger/swagger.json swagger/swagger-dev.json

descriptors: ## Update API compatibility descriptors
../bin/buf build -o descriptor.bin --as-file-descriptor-set .
../bin/buf build -o descriptor.bin --as-file-descriptor-set .
Loading

0 comments on commit 7d2c4fd

Please sign in to comment.