PMM-12530 use loop instead of with_items

percona · Dec 12, 2023 · c9d2b83 · c9d2b83
1 parent 4fa4250
commit c9d2b83
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 6 deletions.
diff --git a/build/ansible/pmm/post-build-actions.yml b/build/ansible/pmm/post-build-actions.yml
@@ -158,7 +158,7 @@
         owner: pmm
         group: pmm
         mode: 0775
-      with_items:
+      loop:
         - absent
         - directory
 

diff --git a/build/ansible/roles/pmm-images/tasks/main.yml b/build/ansible/roles/pmm-images/tasks/main.yml
@@ -100,9 +100,13 @@
 
   when: ansible_virtualization_type == "docker"
 
-- name: Create directories        | Create dirs
-  file: path={{ item }} state=directory owner=pmm group=pmm
-  with_items:
+- name: Create directories
+  file: 
+    path: "{{ item }}"
+    state: directory
+    owner: pmm
+    group: pmm
+  loop:
     - /srv/prometheus/rules
     - /etc/grafana
 

diff --git a/update/ansible/playbook/tasks/update.yml b/update/ansible/playbook/tasks/update.yml
@@ -77,9 +77,12 @@
       debug: var=reread_result.stdout_lines
 
     - name: Restart pmm-managed
-      command: supervisorctl {{ item }} pmm-managed
+      command: "supervisorctl {{ item }} pmm-managed"
       become: true
-      with_items: ["stop", "remove", "add"]
+      loop: 
+        - stop
+        - remove
+        - add
 
     # Give pmm-managed time to update supervisord configuration,
     # and give update UI time to catch up after pmm-managed restart