From fe8e9478160aab8c5a2cedb3e8b0404d6c05a1c2 Mon Sep 17 00:00:00 2001 From: Alex Tymchuk Date: Wed, 28 Jun 2023 12:11:19 +0300 Subject: [PATCH] PMM-7 enable `interfacebloat` linter rule (#2316) * PMM-7 enable `interfacebloat` linter rule * PMM-7 remove temp disables --------- Co-authored-by: Artem Gavrilov --- .golangci.yml | 1 - admin/commands/pmm/server/docker/deps.go | 2 +- managed/services/management/dbaas/deps.go | 2 +- 3 files changed, 2 insertions(+), 3 deletions(-) diff --git a/.golangci.yml b/.golangci.yml index 9705dbb7d6..645ad885e3 100644 --- a/.golangci.yml +++ b/.golangci.yml @@ -114,7 +114,6 @@ linters: - revive - paralleltest - gocognit - - interfacebloat - errcheck # ENDTODO diff --git a/admin/commands/pmm/server/docker/deps.go b/admin/commands/pmm/server/docker/deps.go index 1c5eed963e..b50e1d3ae2 100644 --- a/admin/commands/pmm/server/docker/deps.go +++ b/admin/commands/pmm/server/docker/deps.go @@ -30,7 +30,7 @@ import ( //go:generate ../../../../../bin/mockery -name=Functions -case=snake -inpkg -testonly // Functions contain methods required to interact with Docker. -type Functions interface { +type Functions interface { //nolint:interfacebloat Imager Installer diff --git a/managed/services/management/dbaas/deps.go b/managed/services/management/dbaas/deps.go index 6779827751..eee5bdffd5 100644 --- a/managed/services/management/dbaas/deps.go +++ b/managed/services/management/dbaas/deps.go @@ -97,7 +97,7 @@ type componentsService interface { InstallOperator(context.Context, *dbaasv1beta1.InstallOperatorRequest) (*dbaasv1beta1.InstallOperatorResponse, error) } -type kubernetesClient interface { +type kubernetesClient interface { //nolint:interfacebloat SetKubeconfig(string) error ListDatabaseClusters(context.Context) (*dbaasv1.DatabaseClusterList, error) GetDatabaseCluster(context.Context, string) (*dbaasv1.DatabaseCluster, error)