Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EVEREST-287 Drop DBaaS #2510

Merged
merged 14 commits into from
Sep 28, 2023
Merged

EVEREST-287 Drop DBaaS #2510

merged 14 commits into from
Sep 28, 2023

Conversation

gen1us2k
Copy link
Contributor

PMM-0

Link to the Feature Build: SUBMODULES-0

If this PR adds or removes or alters one or more API endpoints, please review and add or update the relevant API documents as well:

  • API Docs updated

If this PR is related to some other PRs in this or other repositories, please provide links to those PRs:

  • Links to related pull requests (optional).

@gen1us2k gen1us2k requested review from ademidoff, artemgavrilov, idoqo and JiriCtvrtka and removed request for a team September 28, 2023 14:15
@BupycHuk
Copy link
Member

@gen1us2k could you fix merge conflicts?

@gen1us2k
Copy link
Contributor Author

Yep. On it and I'll review it by myself before asking it again

@gen1us2k gen1us2k enabled auto-merge (squash) September 28, 2023 14:37
@codecov
Copy link

codecov bot commented Sep 28, 2023

Codecov Report

Merging #2510 (0cace43) into v3 (bbb794f) will increase coverage by 1.24%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##               v3    #2510      +/-   ##
==========================================
+ Coverage   42.82%   44.07%   +1.24%     
==========================================
  Files         384      360      -24     
  Lines       48345    43035    -5310     
==========================================
- Hits        20706    18969    -1737     
+ Misses      25689    22429    -3260     
+ Partials     1950     1637     -313     
Flag Coverage Δ
admin 10.45% <ø> (+0.04%) ⬆️
agent 53.01% <ø> (-0.16%) ⬇️
vmproxy 68.57% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
managed/cmd/pmm-managed/main.go 0.00% <ø> (ø)
managed/models/database.go 42.91% <ø> (ø)
managed/models/settings.go 100.00% <ø> (ø)
managed/models/settings_helpers.go 69.49% <ø> (+0.38%) ⬆️
managed/services/server/server.go 35.75% <ø> (+0.23%) ⬆️
managed/services/supervisord/supervisord.go 43.82% <ø> (+0.15%) ⬆️
managed/services/victoriametrics/prometheus.go 39.59% <ø> (+0.38%) ⬆️
managed/services/victoriametrics/scrape_configs.go 80.91% <ø> (+2.21%) ⬆️
...anaged/services/victoriametrics/victoriametrics.go 49.81% <ø> (+3.45%) ⬆️
managed/utils/envvars/parser.go 64.44% <ø> (+4.03%) ⬆️

... and 29 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Makefile.include Outdated Show resolved Hide resolved
.github/CODEOWNERS Outdated Show resolved Hide resolved
@gen1us2k
Copy link
Contributor Author

The only failed run
https://github.com/percona/pmm/actions/runs/6340498602/job/17222014123?pr=2510
and I assume that's not related to the changes

@BupycHuk BupycHuk disabled auto-merge September 28, 2023 15:02
@gen1us2k gen1us2k merged commit bf2a099 into v3 Sep 28, 2023
32 checks passed
@gen1us2k gen1us2k deleted the EVEREST-287 branch September 28, 2023 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants