[PER-2574] Icons not loading when noscript tags are present. (#1404)

percy · Oct 19, 2023 · 04146d1 · 04146d1
1 parent d83228a
commit 04146d1
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 1 deletion.
diff --git a/packages/dom/src/clone-dom.js b/packages/dom/src/clone-dom.js
@@ -10,12 +10,17 @@ import applyElementTransformations from './transform-dom';
  * Deep clone a document while also preserving shadow roots
  * returns document fragment
  */
+
+const ignoreTags = ['NOSCRIPT'];
+
 export function cloneNodeAndShadow({ dom, disableShadowDOM }) {
   // clones shadow DOM and light DOM for a given node
   let cloneNode = (node, parent) => {
     let walkTree = (nextn, nextp) => {
       while (nextn) {
-        cloneNode(nextn, nextp);
+        if (!ignoreTags.includes(nextn.nodeName)) {
+          cloneNode(nextn, nextp);
+        }
         nextn = nextn.nextSibling;
       }
     };

diff --git a/packages/dom/test/serialize-dom.test.js b/packages/dom/test/serialize-dom.test.js
@@ -17,6 +17,14 @@ describe('serializeDOM', () => {
     expect(result.html).toContain('Hey Percy $&');
   });
 
+  it('excludes noscript tags when present', () => {
+    withExample('<p>Hey Percy $&</p><noscript>Your browser does not support JavaScript!</noscript>');
+
+    const result = serializeDOM();
+    expect(result.html).not.toContain('<noscript>');
+    expect(result.html).toContain('Hey Percy $&');
+  });
+
   it('optionally returns a stringified response', () => {
     expect(serializeDOM({ stringifyResponse: true }))
       .toMatch('{"html":".*","warnings":\\[\\],"resources":\\[\\]}');