From 4299c3bf9421047c3465d5eb28f821ce56e771aa Mon Sep 17 00:00:00 2001 From: rishigupta1599 Date: Thu, 23 Nov 2023 15:51:05 +0530 Subject: [PATCH] Resolving comments --- packages/core/src/utils.js | 3 ++- packages/core/test/api.test.js | 3 ++- packages/webdriver-utils/src/providers/automateProvider.js | 1 - 3 files changed, 4 insertions(+), 3 deletions(-) diff --git a/packages/core/src/utils.js b/packages/core/src/utils.js index cdb190243..0c69c213b 100644 --- a/packages/core/src/utils.js +++ b/packages/core/src/utils.js @@ -48,7 +48,8 @@ export function percyAutomateRequestHandler(req, percy) { ignoreRegionSelectors: percy.config.snapshot.ignoreRegions?.ignoreRegionSelectors, ignoreRegionXpaths: percy.config.snapshot.ignoreRegions?.ignoreRegionXpaths, considerRegionSelectors: percy.config.snapshot.considerRegions?.considerRegionSelectors, - considerRegionXpaths: percy.config.snapshot.considerRegions?.considerRegionXpaths + considerRegionXpaths: percy.config.snapshot.considerRegions?.considerRegionXpaths, + version: 'v2' }, camelCasedOptions ], (path, prev, next) => { diff --git a/packages/core/test/api.test.js b/packages/core/test/api.test.js index d0a5a620d..8a3f6493b 100644 --- a/packages/core/test/api.test.js +++ b/packages/core/test/api.test.js @@ -307,7 +307,8 @@ describe('API Server', () => { percyCSS: '.global { color: blue }\n.percy-screenshot: { color: red }', ignoreRegionSelectors: ['.selector-global'], ignoreRegionXpaths: ['/xpath-per-screenshot'], - considerRegionXpaths: ['/xpath-global', '/xpath-per-screenshot'] + considerRegionXpaths: ['/xpath-global', '/xpath-per-screenshot'], + version: 'v2' } })); diff --git a/packages/webdriver-utils/src/providers/automateProvider.js b/packages/webdriver-utils/src/providers/automateProvider.js index 882b71902..9ffa6f3bf 100644 --- a/packages/webdriver-utils/src/providers/automateProvider.js +++ b/packages/webdriver-utils/src/providers/automateProvider.js @@ -127,7 +127,6 @@ export default class AutomateProvider extends GenericProvider { if (!this.driver) throw new Error('Driver is null, please initialize driver with createDriver().'); log.debug('Starting actual screenshotting phase'); const dpr = await this.metaData.devicePixelRatio(); - this.options.version = 'v2'; const response = await TimeIt.run('percyScreenshot:screenshot', async () => { return await this.browserstackExecutor('percyScreenshot', { state: 'screenshot',