Percy on Automate: Check if deviceName was passed (#1370)

* Check if deviceName was passed * Updating Tests
percy · Sep 14, 2023 · 4564deb · 4564deb
1 parent b898956
commit 4564deb
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 1 deletion.
diff --git a/packages/webdriver-utils/src/metadata/metaDataResolver.js b/packages/webdriver-utils/src/metadata/metaDataResolver.js
@@ -8,7 +8,8 @@ export default class MetaDataResolver {
     const platform = opts.platformName || opts.platform;
     if (['ios', 'android'].includes(platform.toLowerCase()) ||
       ['ios', 'android'].includes(capabilities?.platformName?.toLowerCase()) ||
-      ['ipad', 'iphone'].includes(capabilities?.device?.toString()?.toLowerCase())) {
+      ['ipad', 'iphone'].includes(capabilities?.device?.toString()?.toLowerCase()) ||
+      opts?.deviceName !== undefined) {
       return new MobileMetaData(driver, capabilities);
     } else {
       return new DesktopMetaData(driver, capabilities);

diff --git a/packages/webdriver-utils/test/metadata/metaDataResolver.test.js b/packages/webdriver-utils/test/metadata/metaDataResolver.test.js
@@ -32,5 +32,19 @@ describe('MetaDataResolver', () => {
       expect(metadata.driver).toEqual(driver);
       expect(metadata.capabilities).toEqual({});
     });
+
+    it('resolves MobileMetaData when deviceName is passed', () => {
+      metadata = MetaDataResolver.resolve(driver, capabilities, { platform: 'Linux', deviceName: 'RX224' });
+      expect(metadata).toBeInstanceOf(MobileMetaData);
+      expect(metadata.driver).toEqual(driver);
+      expect(metadata.capabilities).toEqual({});
+    });
+
+    it('resolves DesktopMetaData when no deviceName is passed', () => {
+      metadata = MetaDataResolver.resolve(driver, capabilities, { platform: 'Linux' });
+      expect(metadata).toBeInstanceOf(DesktopMetaData);
+      expect(metadata.driver).toEqual(driver);
+      expect(metadata.capabilities).toEqual({});
+    });
   });
 });