From a42c13ceca0f799a73aa3b5149571683b08326ee Mon Sep 17 00:00:00 2001 From: Ethan Setnik Date: Wed, 4 Dec 2024 04:58:33 -0500 Subject: [PATCH 1/6] Use correct CircleCI environment variable for pull request detection (#1767) * Use correct CircleCI environment variable for pull request detection https://circleci.com/docs/variables/#built-in-environment-variables:~:text=CIRCLE_PULL_REQUESTS * update tests and fix PERCY_PARALLEL_TOTAL on circle * Update README.md * Revert Update README.md * Revert update readme. * Fix Lint Issue * Update environment.js * Fix CircleCI test --------- Co-authored-by: ninadbstack <60422475+ninadbstack@users.noreply.github.com> Co-authored-by: Pankaj Yadav --- packages/env/src/environment.js | 7 ++++++- packages/env/test/circle.test.js | 9 +++++++-- 2 files changed, 13 insertions(+), 3 deletions(-) diff --git a/packages/env/src/environment.js b/packages/env/src/environment.js index e8c059eb3..325a4d17c 100644 --- a/packages/env/src/environment.js +++ b/packages/env/src/environment.js @@ -178,7 +178,7 @@ export class PercyEnv { case 'jenkins': return this.vars.CHANGE_ID; case 'circle': - return this.vars.CI_PULL_REQUESTS?.split('/').slice(-1)[0]; + return this.vars.CIRCLE_PULL_REQUESTS?.split('/').slice(-1)[0]; case 'drone': return this.vars.CI_PULL_REQUEST; case 'semaphore': @@ -212,6 +212,11 @@ export class PercyEnv { // parallel total & nonce get parallel() { let total = parseInt(this.vars.PERCY_PARALLEL_TOTAL, 10); + + if (this.ci === 'circle') { + total = parseInt(this.vars.CIRCLE_NODE_TOTAL, 10); + } + if (!Number.isInteger(total)) total = null; // no nonce if no total diff --git a/packages/env/test/circle.test.js b/packages/env/test/circle.test.js index 6770e1d49..ef84f3753 100644 --- a/packages/env/test/circle.test.js +++ b/packages/env/test/circle.test.js @@ -5,10 +5,10 @@ describe('CircleCI', () => { beforeEach(() => { env = new PercyEnv({ - PERCY_PARALLEL_TOTAL: '-1', + CIRCLE_NODE_TOTAL: '-1', CIRCLE_BRANCH: 'circle-branch', CIRCLE_SHA1: 'circle-commit-sha', - CI_PULL_REQUESTS: 'https://github.com/owner/repo-name/pull/123', + CIRCLE_PULL_REQUESTS: 'https://github.com/owner/repo-name/pull/123', CIRCLE_BUILD_NUM: 'build-number', CIRCLECI: 'true' }); @@ -29,4 +29,9 @@ describe('CircleCI', () => { env = new PercyEnv({ ...env.vars, CIRCLE_WORKFLOW_ID: 'workflow-id' }); expect(env).toHaveProperty('parallel.nonce', 'workflow-id'); }); + + it('has the correct parallel total', () => { + env = new PercyEnv({ ...env.vars, CIRCLE_NODE_TOTAL: '2' }); + expect(env).toHaveProperty('parallel.total', 2); + }); }); From 46870b6b3259c3770ca2c5563ca9ad8f1d725681 Mon Sep 17 00:00:00 2001 From: Pankaj Yadav Date: Wed, 4 Dec 2024 15:44:05 +0530 Subject: [PATCH 2/6] =?UTF-8?q?=F0=9F=94=96=20v1.30.5-beta.0=20(#1811)?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- lerna.json | 2 +- packages/cli-app/package.json | 8 ++++---- packages/cli-build/package.json | 6 +++--- packages/cli-command/package.json | 10 +++++----- packages/cli-config/package.json | 6 +++--- packages/cli-exec/package.json | 8 ++++---- packages/cli-snapshot/package.json | 6 +++--- packages/cli-upload/package.json | 6 +++--- packages/cli/package.json | 22 +++++++++++----------- packages/client/package.json | 8 ++++---- packages/config/package.json | 6 +++--- packages/core/package.json | 14 +++++++------- packages/dom/package.json | 4 ++-- packages/env/package.json | 6 +++--- packages/logger/package.json | 4 ++-- packages/sdk-utils/package.json | 4 ++-- packages/webdriver-utils/package.json | 8 ++++---- 17 files changed, 64 insertions(+), 64 deletions(-) diff --git a/lerna.json b/lerna.json index c8ebc6d9f..cf8f38d97 100644 --- a/lerna.json +++ b/lerna.json @@ -1,5 +1,5 @@ { - "version": "1.30.4", + "version": "1.30.5-beta.0", "packages": [ "packages/*" ], diff --git a/packages/cli-app/package.json b/packages/cli-app/package.json index 42cff58a6..270e8f0b0 100644 --- a/packages/cli-app/package.json +++ b/packages/cli-app/package.json @@ -1,6 +1,6 @@ { "name": "@percy/cli-app", - "version": "1.30.4", + "version": "1.30.5-beta.0", "license": "MIT", "repository": { "type": "git", @@ -9,7 +9,7 @@ }, "publishConfig": { "access": "public", - "tag": "latest" + "tag": "beta" }, "engines": { "node": ">=14" @@ -33,7 +33,7 @@ ] }, "dependencies": { - "@percy/cli-command": "1.30.4", - "@percy/cli-exec": "1.30.4" + "@percy/cli-command": "1.30.5-beta.0", + "@percy/cli-exec": "1.30.5-beta.0" } } diff --git a/packages/cli-build/package.json b/packages/cli-build/package.json index 63c345fb4..62e9ff597 100644 --- a/packages/cli-build/package.json +++ b/packages/cli-build/package.json @@ -1,6 +1,6 @@ { "name": "@percy/cli-build", - "version": "1.30.4", + "version": "1.30.5-beta.0", "license": "MIT", "repository": { "type": "git", @@ -9,7 +9,7 @@ }, "publishConfig": { "access": "public", - "tag": "latest" + "tag": "beta" }, "engines": { "node": ">=14" @@ -33,6 +33,6 @@ ] }, "dependencies": { - "@percy/cli-command": "1.30.4" + "@percy/cli-command": "1.30.5-beta.0" } } diff --git a/packages/cli-command/package.json b/packages/cli-command/package.json index 6565eda50..0f0d0c136 100644 --- a/packages/cli-command/package.json +++ b/packages/cli-command/package.json @@ -1,6 +1,6 @@ { "name": "@percy/cli-command", - "version": "1.30.4", + "version": "1.30.5-beta.0", "license": "MIT", "repository": { "type": "git", @@ -9,7 +9,7 @@ }, "publishConfig": { "access": "public", - "tag": "latest" + "tag": "beta" }, "files": [ "dist", @@ -36,8 +36,8 @@ "test:coverage": "yarn test --coverage" }, "dependencies": { - "@percy/config": "1.30.4", - "@percy/core": "1.30.4", - "@percy/logger": "1.30.4" + "@percy/config": "1.30.5-beta.0", + "@percy/core": "1.30.5-beta.0", + "@percy/logger": "1.30.5-beta.0" } } diff --git a/packages/cli-config/package.json b/packages/cli-config/package.json index 8f559a718..3f623f40f 100644 --- a/packages/cli-config/package.json +++ b/packages/cli-config/package.json @@ -1,6 +1,6 @@ { "name": "@percy/cli-config", - "version": "1.30.4", + "version": "1.30.5-beta.0", "license": "MIT", "repository": { "type": "git", @@ -9,7 +9,7 @@ }, "publishConfig": { "access": "public", - "tag": "latest" + "tag": "beta" }, "engines": { "node": ">=14" @@ -33,6 +33,6 @@ ] }, "dependencies": { - "@percy/cli-command": "1.30.4" + "@percy/cli-command": "1.30.5-beta.0" } } diff --git a/packages/cli-exec/package.json b/packages/cli-exec/package.json index dcffd39f6..1b1a041a4 100644 --- a/packages/cli-exec/package.json +++ b/packages/cli-exec/package.json @@ -1,6 +1,6 @@ { "name": "@percy/cli-exec", - "version": "1.30.4", + "version": "1.30.5-beta.0", "license": "MIT", "repository": { "type": "git", @@ -9,7 +9,7 @@ }, "publishConfig": { "access": "public", - "tag": "latest" + "tag": "beta" }, "engines": { "node": ">=14" @@ -33,8 +33,8 @@ ] }, "dependencies": { - "@percy/cli-command": "1.30.4", - "@percy/logger": "1.30.4", + "@percy/cli-command": "1.30.5-beta.0", + "@percy/logger": "1.30.5-beta.0", "cross-spawn": "^7.0.3", "which": "^2.0.2" } diff --git a/packages/cli-snapshot/package.json b/packages/cli-snapshot/package.json index d4677420d..8cc25450c 100644 --- a/packages/cli-snapshot/package.json +++ b/packages/cli-snapshot/package.json @@ -1,6 +1,6 @@ { "name": "@percy/cli-snapshot", - "version": "1.30.4", + "version": "1.30.5-beta.0", "license": "MIT", "repository": { "type": "git", @@ -9,7 +9,7 @@ }, "publishConfig": { "access": "public", - "tag": "latest" + "tag": "beta" }, "engines": { "node": ">=14" @@ -33,7 +33,7 @@ ] }, "dependencies": { - "@percy/cli-command": "1.30.4", + "@percy/cli-command": "1.30.5-beta.0", "yaml": "^2.0.0" } } diff --git a/packages/cli-upload/package.json b/packages/cli-upload/package.json index ea1ed9215..5305875d1 100644 --- a/packages/cli-upload/package.json +++ b/packages/cli-upload/package.json @@ -1,6 +1,6 @@ { "name": "@percy/cli-upload", - "version": "1.30.4", + "version": "1.30.5-beta.0", "license": "MIT", "repository": { "type": "git", @@ -9,7 +9,7 @@ }, "publishConfig": { "access": "public", - "tag": "latest" + "tag": "beta" }, "engines": { "node": ">=14" @@ -33,7 +33,7 @@ ] }, "dependencies": { - "@percy/cli-command": "1.30.4", + "@percy/cli-command": "1.30.5-beta.0", "fast-glob": "^3.2.11", "image-size": "^1.0.0" } diff --git a/packages/cli/package.json b/packages/cli/package.json index b9154a39f..65267427f 100644 --- a/packages/cli/package.json +++ b/packages/cli/package.json @@ -1,6 +1,6 @@ { "name": "@percy/cli", - "version": "1.30.4", + "version": "1.30.5-beta.0", "license": "MIT", "repository": { "type": "git", @@ -9,7 +9,7 @@ }, "publishConfig": { "access": "public", - "tag": "latest" + "tag": "beta" }, "files": [ "bin", @@ -31,14 +31,14 @@ "test:coverage": "yarn test --coverage" }, "dependencies": { - "@percy/cli-app": "1.30.4", - "@percy/cli-build": "1.30.4", - "@percy/cli-command": "1.30.4", - "@percy/cli-config": "1.30.4", - "@percy/cli-exec": "1.30.4", - "@percy/cli-snapshot": "1.30.4", - "@percy/cli-upload": "1.30.4", - "@percy/client": "1.30.4", - "@percy/logger": "1.30.4" + "@percy/cli-app": "1.30.5-beta.0", + "@percy/cli-build": "1.30.5-beta.0", + "@percy/cli-command": "1.30.5-beta.0", + "@percy/cli-config": "1.30.5-beta.0", + "@percy/cli-exec": "1.30.5-beta.0", + "@percy/cli-snapshot": "1.30.5-beta.0", + "@percy/cli-upload": "1.30.5-beta.0", + "@percy/client": "1.30.5-beta.0", + "@percy/logger": "1.30.5-beta.0" } } diff --git a/packages/client/package.json b/packages/client/package.json index a732422c1..63b6a833f 100644 --- a/packages/client/package.json +++ b/packages/client/package.json @@ -1,6 +1,6 @@ { "name": "@percy/client", - "version": "1.30.4", + "version": "1.30.5-beta.0", "license": "MIT", "repository": { "type": "git", @@ -9,7 +9,7 @@ }, "publishConfig": { "access": "public", - "tag": "latest" + "tag": "beta" }, "engines": { "node": ">=14" @@ -33,8 +33,8 @@ "test:coverage": "yarn test --coverage" }, "dependencies": { - "@percy/env": "1.30.4", - "@percy/logger": "1.30.4", + "@percy/env": "1.30.5-beta.0", + "@percy/logger": "1.30.5-beta.0", "pako": "^2.1.0" } } diff --git a/packages/config/package.json b/packages/config/package.json index f9335cbd5..1b584e0ee 100644 --- a/packages/config/package.json +++ b/packages/config/package.json @@ -1,6 +1,6 @@ { "name": "@percy/config", - "version": "1.30.4", + "version": "1.30.5-beta.0", "license": "MIT", "repository": { "type": "git", @@ -9,7 +9,7 @@ }, "publishConfig": { "access": "public", - "tag": "latest" + "tag": "beta" }, "engines": { "node": ">=14" @@ -38,7 +38,7 @@ "test:types": "tsd" }, "dependencies": { - "@percy/logger": "1.30.4", + "@percy/logger": "1.30.5-beta.0", "ajv": "^8.6.2", "cosmiconfig": "^8.0.0", "yaml": "^2.0.0" diff --git a/packages/core/package.json b/packages/core/package.json index f635621ee..656e2318d 100644 --- a/packages/core/package.json +++ b/packages/core/package.json @@ -1,6 +1,6 @@ { "name": "@percy/core", - "version": "1.30.4", + "version": "1.30.5-beta.0", "license": "MIT", "repository": { "type": "git", @@ -9,7 +9,7 @@ }, "publishConfig": { "access": "public", - "tag": "latest" + "tag": "beta" }, "engines": { "node": ">=14" @@ -43,11 +43,11 @@ "test:types": "tsd" }, "dependencies": { - "@percy/client": "1.30.4", - "@percy/config": "1.30.4", - "@percy/dom": "1.30.4", - "@percy/logger": "1.30.4", - "@percy/webdriver-utils": "1.30.4", + "@percy/client": "1.30.5-beta.0", + "@percy/config": "1.30.5-beta.0", + "@percy/dom": "1.30.5-beta.0", + "@percy/logger": "1.30.5-beta.0", + "@percy/webdriver-utils": "1.30.5-beta.0", "content-disposition": "^0.5.4", "cross-spawn": "^7.0.3", "extract-zip": "^2.0.1", diff --git a/packages/dom/package.json b/packages/dom/package.json index 46c35d474..ae8af1cb9 100644 --- a/packages/dom/package.json +++ b/packages/dom/package.json @@ -1,6 +1,6 @@ { "name": "@percy/dom", - "version": "1.30.4", + "version": "1.30.5-beta.0", "license": "MIT", "repository": { "type": "git", @@ -9,7 +9,7 @@ }, "publishConfig": { "access": "public", - "tag": "latest" + "tag": "beta" }, "main": "dist/bundle.js", "browser": "dist/bundle.js", diff --git a/packages/env/package.json b/packages/env/package.json index 1b8bb7ea2..a94bca778 100644 --- a/packages/env/package.json +++ b/packages/env/package.json @@ -1,6 +1,6 @@ { "name": "@percy/env", - "version": "1.30.4", + "version": "1.30.5-beta.0", "license": "MIT", "repository": { "type": "git", @@ -9,7 +9,7 @@ }, "publishConfig": { "access": "public", - "tag": "latest" + "tag": "beta" }, "engines": { "node": ">=14" @@ -32,6 +32,6 @@ "test:coverage": "yarn test --coverage" }, "dependencies": { - "@percy/logger": "1.30.4" + "@percy/logger": "1.30.5-beta.0" } } diff --git a/packages/logger/package.json b/packages/logger/package.json index e52fb9ecf..e751a7191 100644 --- a/packages/logger/package.json +++ b/packages/logger/package.json @@ -1,6 +1,6 @@ { "name": "@percy/logger", - "version": "1.30.4", + "version": "1.30.5-beta.0", "license": "MIT", "repository": { "type": "git", @@ -9,7 +9,7 @@ }, "publishConfig": { "access": "public", - "tag": "latest" + "tag": "beta" }, "engines": { "node": ">=14" diff --git a/packages/sdk-utils/package.json b/packages/sdk-utils/package.json index 2174618ec..5774b98e2 100644 --- a/packages/sdk-utils/package.json +++ b/packages/sdk-utils/package.json @@ -1,6 +1,6 @@ { "name": "@percy/sdk-utils", - "version": "1.30.4", + "version": "1.30.5-beta.0", "license": "MIT", "repository": { "type": "git", @@ -9,7 +9,7 @@ }, "publishConfig": { "access": "public", - "tag": "latest" + "tag": "beta" }, "engines": { "node": ">=14" diff --git a/packages/webdriver-utils/package.json b/packages/webdriver-utils/package.json index 58e1a79f0..d402ff730 100644 --- a/packages/webdriver-utils/package.json +++ b/packages/webdriver-utils/package.json @@ -1,6 +1,6 @@ { "name": "@percy/webdriver-utils", - "version": "1.30.4", + "version": "1.30.5-beta.0", "license": "MIT", "repository": { "type": "git", @@ -9,7 +9,7 @@ }, "publishConfig": { "access": "public", - "tag": "latest" + "tag": "beta" }, "engines": { "node": ">=14" @@ -29,7 +29,7 @@ "test:coverage": "yarn test --coverage" }, "dependencies": { - "@percy/config": "1.30.4", - "@percy/sdk-utils": "1.30.4" + "@percy/config": "1.30.5-beta.0", + "@percy/sdk-utils": "1.30.5-beta.0" } } From 7d47169e96d9c3e8264770d07748080073c9d86a Mon Sep 17 00:00:00 2001 From: Pankaj Yadav Date: Thu, 5 Dec 2024 15:04:30 +0530 Subject: [PATCH 3/6] Add override for CircleCI node total (#1812) --- packages/env/src/environment.js | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/packages/env/src/environment.js b/packages/env/src/environment.js index 325a4d17c..a99e4d331 100644 --- a/packages/env/src/environment.js +++ b/packages/env/src/environment.js @@ -212,13 +212,15 @@ export class PercyEnv { // parallel total & nonce get parallel() { let total = parseInt(this.vars.PERCY_PARALLEL_TOTAL, 10); + if (!Number.isInteger(total)) total = null; - if (this.ci === 'circle') { - total = parseInt(this.vars.CIRCLE_NODE_TOTAL, 10); + if (total === null) { + switch (this.ci) { + case 'circle': + total = parseInt(this.vars.CIRCLE_NODE_TOTAL, 10); + } } - if (!Number.isInteger(total)) total = null; - // no nonce if no total let nonce = total && (() => { if (this.vars.PERCY_PARALLEL_NONCE) { From 4951bc46ffffcd2fd5947f6aa88fd7eb68a34ef3 Mon Sep 17 00:00:00 2001 From: Pankaj Yadav Date: Thu, 5 Dec 2024 15:18:36 +0530 Subject: [PATCH 4/6] =?UTF-8?q?=F0=9F=94=96=20v1.30.5-beta.1=20(#1813)?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- lerna.json | 2 +- packages/cli-app/package.json | 6 +++--- packages/cli-build/package.json | 4 ++-- packages/cli-command/package.json | 8 ++++---- packages/cli-config/package.json | 4 ++-- packages/cli-exec/package.json | 6 +++--- packages/cli-snapshot/package.json | 4 ++-- packages/cli-upload/package.json | 4 ++-- packages/cli/package.json | 20 ++++++++++---------- packages/client/package.json | 6 +++--- packages/config/package.json | 4 ++-- packages/core/package.json | 12 ++++++------ packages/dom/package.json | 2 +- packages/env/package.json | 4 ++-- packages/logger/package.json | 2 +- packages/sdk-utils/package.json | 2 +- packages/webdriver-utils/package.json | 6 +++--- 17 files changed, 48 insertions(+), 48 deletions(-) diff --git a/lerna.json b/lerna.json index cf8f38d97..558536d8d 100644 --- a/lerna.json +++ b/lerna.json @@ -1,5 +1,5 @@ { - "version": "1.30.5-beta.0", + "version": "1.30.5-beta.1", "packages": [ "packages/*" ], diff --git a/packages/cli-app/package.json b/packages/cli-app/package.json index 270e8f0b0..11665b6a9 100644 --- a/packages/cli-app/package.json +++ b/packages/cli-app/package.json @@ -1,6 +1,6 @@ { "name": "@percy/cli-app", - "version": "1.30.5-beta.0", + "version": "1.30.5-beta.1", "license": "MIT", "repository": { "type": "git", @@ -33,7 +33,7 @@ ] }, "dependencies": { - "@percy/cli-command": "1.30.5-beta.0", - "@percy/cli-exec": "1.30.5-beta.0" + "@percy/cli-command": "1.30.5-beta.1", + "@percy/cli-exec": "1.30.5-beta.1" } } diff --git a/packages/cli-build/package.json b/packages/cli-build/package.json index 62e9ff597..166a21c69 100644 --- a/packages/cli-build/package.json +++ b/packages/cli-build/package.json @@ -1,6 +1,6 @@ { "name": "@percy/cli-build", - "version": "1.30.5-beta.0", + "version": "1.30.5-beta.1", "license": "MIT", "repository": { "type": "git", @@ -33,6 +33,6 @@ ] }, "dependencies": { - "@percy/cli-command": "1.30.5-beta.0" + "@percy/cli-command": "1.30.5-beta.1" } } diff --git a/packages/cli-command/package.json b/packages/cli-command/package.json index 0f0d0c136..0d5228235 100644 --- a/packages/cli-command/package.json +++ b/packages/cli-command/package.json @@ -1,6 +1,6 @@ { "name": "@percy/cli-command", - "version": "1.30.5-beta.0", + "version": "1.30.5-beta.1", "license": "MIT", "repository": { "type": "git", @@ -36,8 +36,8 @@ "test:coverage": "yarn test --coverage" }, "dependencies": { - "@percy/config": "1.30.5-beta.0", - "@percy/core": "1.30.5-beta.0", - "@percy/logger": "1.30.5-beta.0" + "@percy/config": "1.30.5-beta.1", + "@percy/core": "1.30.5-beta.1", + "@percy/logger": "1.30.5-beta.1" } } diff --git a/packages/cli-config/package.json b/packages/cli-config/package.json index 3f623f40f..3c6931ee3 100644 --- a/packages/cli-config/package.json +++ b/packages/cli-config/package.json @@ -1,6 +1,6 @@ { "name": "@percy/cli-config", - "version": "1.30.5-beta.0", + "version": "1.30.5-beta.1", "license": "MIT", "repository": { "type": "git", @@ -33,6 +33,6 @@ ] }, "dependencies": { - "@percy/cli-command": "1.30.5-beta.0" + "@percy/cli-command": "1.30.5-beta.1" } } diff --git a/packages/cli-exec/package.json b/packages/cli-exec/package.json index 1b1a041a4..a4bdc3ff6 100644 --- a/packages/cli-exec/package.json +++ b/packages/cli-exec/package.json @@ -1,6 +1,6 @@ { "name": "@percy/cli-exec", - "version": "1.30.5-beta.0", + "version": "1.30.5-beta.1", "license": "MIT", "repository": { "type": "git", @@ -33,8 +33,8 @@ ] }, "dependencies": { - "@percy/cli-command": "1.30.5-beta.0", - "@percy/logger": "1.30.5-beta.0", + "@percy/cli-command": "1.30.5-beta.1", + "@percy/logger": "1.30.5-beta.1", "cross-spawn": "^7.0.3", "which": "^2.0.2" } diff --git a/packages/cli-snapshot/package.json b/packages/cli-snapshot/package.json index 8cc25450c..31b103665 100644 --- a/packages/cli-snapshot/package.json +++ b/packages/cli-snapshot/package.json @@ -1,6 +1,6 @@ { "name": "@percy/cli-snapshot", - "version": "1.30.5-beta.0", + "version": "1.30.5-beta.1", "license": "MIT", "repository": { "type": "git", @@ -33,7 +33,7 @@ ] }, "dependencies": { - "@percy/cli-command": "1.30.5-beta.0", + "@percy/cli-command": "1.30.5-beta.1", "yaml": "^2.0.0" } } diff --git a/packages/cli-upload/package.json b/packages/cli-upload/package.json index 5305875d1..24a02b709 100644 --- a/packages/cli-upload/package.json +++ b/packages/cli-upload/package.json @@ -1,6 +1,6 @@ { "name": "@percy/cli-upload", - "version": "1.30.5-beta.0", + "version": "1.30.5-beta.1", "license": "MIT", "repository": { "type": "git", @@ -33,7 +33,7 @@ ] }, "dependencies": { - "@percy/cli-command": "1.30.5-beta.0", + "@percy/cli-command": "1.30.5-beta.1", "fast-glob": "^3.2.11", "image-size": "^1.0.0" } diff --git a/packages/cli/package.json b/packages/cli/package.json index 65267427f..d239ae31e 100644 --- a/packages/cli/package.json +++ b/packages/cli/package.json @@ -1,6 +1,6 @@ { "name": "@percy/cli", - "version": "1.30.5-beta.0", + "version": "1.30.5-beta.1", "license": "MIT", "repository": { "type": "git", @@ -31,14 +31,14 @@ "test:coverage": "yarn test --coverage" }, "dependencies": { - "@percy/cli-app": "1.30.5-beta.0", - "@percy/cli-build": "1.30.5-beta.0", - "@percy/cli-command": "1.30.5-beta.0", - "@percy/cli-config": "1.30.5-beta.0", - "@percy/cli-exec": "1.30.5-beta.0", - "@percy/cli-snapshot": "1.30.5-beta.0", - "@percy/cli-upload": "1.30.5-beta.0", - "@percy/client": "1.30.5-beta.0", - "@percy/logger": "1.30.5-beta.0" + "@percy/cli-app": "1.30.5-beta.1", + "@percy/cli-build": "1.30.5-beta.1", + "@percy/cli-command": "1.30.5-beta.1", + "@percy/cli-config": "1.30.5-beta.1", + "@percy/cli-exec": "1.30.5-beta.1", + "@percy/cli-snapshot": "1.30.5-beta.1", + "@percy/cli-upload": "1.30.5-beta.1", + "@percy/client": "1.30.5-beta.1", + "@percy/logger": "1.30.5-beta.1" } } diff --git a/packages/client/package.json b/packages/client/package.json index 63b6a833f..1c475c882 100644 --- a/packages/client/package.json +++ b/packages/client/package.json @@ -1,6 +1,6 @@ { "name": "@percy/client", - "version": "1.30.5-beta.0", + "version": "1.30.5-beta.1", "license": "MIT", "repository": { "type": "git", @@ -33,8 +33,8 @@ "test:coverage": "yarn test --coverage" }, "dependencies": { - "@percy/env": "1.30.5-beta.0", - "@percy/logger": "1.30.5-beta.0", + "@percy/env": "1.30.5-beta.1", + "@percy/logger": "1.30.5-beta.1", "pako": "^2.1.0" } } diff --git a/packages/config/package.json b/packages/config/package.json index 1b584e0ee..0fdc209a4 100644 --- a/packages/config/package.json +++ b/packages/config/package.json @@ -1,6 +1,6 @@ { "name": "@percy/config", - "version": "1.30.5-beta.0", + "version": "1.30.5-beta.1", "license": "MIT", "repository": { "type": "git", @@ -38,7 +38,7 @@ "test:types": "tsd" }, "dependencies": { - "@percy/logger": "1.30.5-beta.0", + "@percy/logger": "1.30.5-beta.1", "ajv": "^8.6.2", "cosmiconfig": "^8.0.0", "yaml": "^2.0.0" diff --git a/packages/core/package.json b/packages/core/package.json index 656e2318d..f5369201e 100644 --- a/packages/core/package.json +++ b/packages/core/package.json @@ -1,6 +1,6 @@ { "name": "@percy/core", - "version": "1.30.5-beta.0", + "version": "1.30.5-beta.1", "license": "MIT", "repository": { "type": "git", @@ -43,11 +43,11 @@ "test:types": "tsd" }, "dependencies": { - "@percy/client": "1.30.5-beta.0", - "@percy/config": "1.30.5-beta.0", - "@percy/dom": "1.30.5-beta.0", - "@percy/logger": "1.30.5-beta.0", - "@percy/webdriver-utils": "1.30.5-beta.0", + "@percy/client": "1.30.5-beta.1", + "@percy/config": "1.30.5-beta.1", + "@percy/dom": "1.30.5-beta.1", + "@percy/logger": "1.30.5-beta.1", + "@percy/webdriver-utils": "1.30.5-beta.1", "content-disposition": "^0.5.4", "cross-spawn": "^7.0.3", "extract-zip": "^2.0.1", diff --git a/packages/dom/package.json b/packages/dom/package.json index ae8af1cb9..e8d8ab725 100644 --- a/packages/dom/package.json +++ b/packages/dom/package.json @@ -1,6 +1,6 @@ { "name": "@percy/dom", - "version": "1.30.5-beta.0", + "version": "1.30.5-beta.1", "license": "MIT", "repository": { "type": "git", diff --git a/packages/env/package.json b/packages/env/package.json index a94bca778..8fbea135d 100644 --- a/packages/env/package.json +++ b/packages/env/package.json @@ -1,6 +1,6 @@ { "name": "@percy/env", - "version": "1.30.5-beta.0", + "version": "1.30.5-beta.1", "license": "MIT", "repository": { "type": "git", @@ -32,6 +32,6 @@ "test:coverage": "yarn test --coverage" }, "dependencies": { - "@percy/logger": "1.30.5-beta.0" + "@percy/logger": "1.30.5-beta.1" } } diff --git a/packages/logger/package.json b/packages/logger/package.json index e751a7191..86f842b22 100644 --- a/packages/logger/package.json +++ b/packages/logger/package.json @@ -1,6 +1,6 @@ { "name": "@percy/logger", - "version": "1.30.5-beta.0", + "version": "1.30.5-beta.1", "license": "MIT", "repository": { "type": "git", diff --git a/packages/sdk-utils/package.json b/packages/sdk-utils/package.json index 5774b98e2..9ca05ebe6 100644 --- a/packages/sdk-utils/package.json +++ b/packages/sdk-utils/package.json @@ -1,6 +1,6 @@ { "name": "@percy/sdk-utils", - "version": "1.30.5-beta.0", + "version": "1.30.5-beta.1", "license": "MIT", "repository": { "type": "git", diff --git a/packages/webdriver-utils/package.json b/packages/webdriver-utils/package.json index d402ff730..f6dd8d708 100644 --- a/packages/webdriver-utils/package.json +++ b/packages/webdriver-utils/package.json @@ -1,6 +1,6 @@ { "name": "@percy/webdriver-utils", - "version": "1.30.5-beta.0", + "version": "1.30.5-beta.1", "license": "MIT", "repository": { "type": "git", @@ -29,7 +29,7 @@ "test:coverage": "yarn test --coverage" }, "dependencies": { - "@percy/config": "1.30.5-beta.0", - "@percy/sdk-utils": "1.30.5-beta.0" + "@percy/config": "1.30.5-beta.1", + "@percy/sdk-utils": "1.30.5-beta.1" } } From 8d278a26a00f74d46edaaffbb72473b1f3e1ce2d Mon Sep 17 00:00:00 2001 From: Shivam singh <140813296+this-is-shivamsingh@users.noreply.github.com> Date: Wed, 11 Dec 2024 19:22:30 +0530 Subject: [PATCH 5/6] Fix[ISSUE_1819]: Support for serialising ShadowRoot Element for Chrome 131 onwards (#1820) * feat: added support for shadowRoot elements for custom templates and slot elements * chore: test fix --- packages/dom/src/clone-dom.js | 16 ++++----- packages/dom/src/serialize-dom.js | 6 +++- packages/dom/test/helpers.js | 47 +++++++++++++++++++++++++ packages/dom/test/serialize-dom.test.js | 22 +++++++++++- 4 files changed, 81 insertions(+), 10 deletions(-) diff --git a/packages/dom/src/clone-dom.js b/packages/dom/src/clone-dom.js index 938d54f21..e73a54e2d 100644 --- a/packages/dom/src/clone-dom.js +++ b/packages/dom/src/clone-dom.js @@ -84,20 +84,20 @@ export function cloneNodeAndShadow(ctx) { /** * Use `getInnerHTML()` to serialize shadow dom as