Changes for new cert (#1609)

percy · Jun 4, 2024 · e907b3d · e907b3d
1 parent 866f110
commit e907b3d
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/.github/workflows/executable.yml b/.github/workflows/executable.yml
@@ -17,6 +17,8 @@ jobs:
           APPLE_DEV_CERT: ${{secrets.APPLE_DEV_CERT}}
           APPLE_ID_USERNAME: ${{secrets.APPLE_ID_USERNAME}}
           APPLE_ID_KEY: ${{secrets.APPLE_ID_KEY}}
+          APPLE_CERT_KEY: ${{secrets.APPLE_CERT_KEY}}
+          APPLE_TEAM_ID: ${{secrets.APPLE_TEAM_ID}}
       - name: Verify executable
         run: ./percy --version
       - name: Upload win artifact

diff --git a/scripts/executable.sh b/scripts/executable.sh
@@ -56,20 +56,20 @@ mv run-win.exe percy.exe && chmod +x percy.exe
 echo "$APPLE_DEV_CERT" | base64 -d > AppleDevIDApp.p12
 
 security create-keychain -p percy percy.keychain
-security import AppleDevIDApp.p12 -t agg -k percy.keychain -P ChaiTime -A
+security import AppleDevIDApp.p12 -t agg -k percy.keychain -P $APPLE_CERT_KEY -A
 security list-keychains -s ~/Library/Keychains/percy.keychain
 security default-keychain -s ~/Library/Keychains/percy.keychain
 security unlock-keychain -p "percy" ~/Library/Keychains/percy.keychain
 security set-keychain-settings -t 3600 -l ~/Library/Keychains/percy.keychain
 security set-key-partition-list -S apple-tool:,apple:,codesign: -s -k percy ~/Library/Keychains/percy.keychain-db
 
-codesign  --force --verbose=4 -s "Developer ID Application: BrowserStack Inc (763K6K6H44)" --options runtime --entitlements scripts/files/entitlement.plist --keychain ~/Library/Keychains/percy.keychain percy-osx
+codesign  --force --verbose=4 -s "Developer ID Application: BrowserStack Inc ($APPLE_TEAM_ID)" --options runtime --entitlements scripts/files/entitlement.plist --keychain ~/Library/Keychains/percy.keychain percy-osx
 
 # Create zip file for uploading as assets
 zip percy-linux.zip percy
 mv percy-osx percy
 zip percy-osx.zip percy
 
-xcrun notarytool submit --apple-id "$APPLE_ID_USERNAME" --password $APPLE_ID_KEY --team-id 763K6K6H44 percy-osx.zip --wait
+xcrun notarytool submit --apple-id "$APPLE_ID_USERNAME" --password $APPLE_ID_KEY --team-id $APPLE_TEAM_ID percy-osx.zip --wait
 
 cleanup