Skip to content

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

storybook field is no longer working in the config file #1373

Closed
AlexisCharp opened this issue Sep 15, 2023 · 1 comment
Closed

storybook field is no longer working in the config file #1373

AlexisCharp opened this issue Sep 15, 2023 · 1 comment

Comments

@AlexisCharp
Copy link

The problem

Hello,
I have recently updated @percy/cli from v1.24.2 to v1.27.1. I then saw the number of taken snapshot increase.
In my configuration, I have these lines :

storybook:
  include: ['Percy/.*']

It was working previously but now when running the percy config:validate command, it says :

[percy] Invalid config:
[percy] - storybook: unknown property

Environment

  • Node version: 18.15.0
  • @percy/cli version: 1.27.1
  • @percy/storybook version: 4.3.6

Debug logs

[percy] Found config file: .percy.yml
[percy] Invalid config:
[percy] - storybook: unknown property

Code to reproduce issue

My full config :

version: 2
snapshot:
  widths:
    - 375
    - 768
    - 1280
  minHeight: 1024
  enableJavascript: true
discovery:
  networkIdleTimeout: 100
storybook:
  include: ['Percy/.*']
@AlexisCharp AlexisCharp changed the title storybook field is not longer working in the config file storybook field is no longer working in the config file Sep 15, 2023
@itsjwala
Copy link
Contributor

Seems mostly related to local dependency issue, I can't seem to reproduce this.

can you check if the dependency are really updated in node_modules/@percy/..?

@percy percy locked and limited conversation to collaborators Sep 25, 2023
@itsjwala itsjwala converted this issue into discussion #1379 Sep 25, 2023

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants