Adding check for correct SDK for percy product #1522
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rishigupta1599
requested review from
prklm10,
pankaj443,
a team,
yashdsaraf and
chinmay-browserstack
and removed request for
a team
prklm10
reviewed
Feb 19, 2024
prklm10
approved these changes
Feb 19, 2024
|
So we already have checks in all SDK's if command called and projectType is same. if it's not same it should throw error. so this might not be required. |
chinmay-browserstack
approved these changes
Feb 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added validation for the case where the correct token and cli flow is used but sdk used is wrong.
For exp: -> App Percy Token is used and cli server is also started using app:exec which will create correct App Percy Build but as percy_screenshot is common in both App Percy and Percy on Automate it can be possible to trigger percy_screenshot using Automate SDK which should not be the case ideally.
We are relying on build type and the endpoint called to determine which SDK would have been used and in which build