Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Base64 encoded SVGs cause error when capturing #1586

Closed
ajoneil opened this issue Apr 30, 2024 · 5 comments
Closed

Base64 encoded SVGs cause error when capturing #1586

ajoneil opened this issue Apr 30, 2024 · 5 comments
Labels
🍞 stale Closed due to inactivity

Comments

@ajoneil
Copy link

ajoneil commented Apr 30, 2024

The problem

We have a base64 encoded SVG image on our page, and our tests work when Percy snapshots are not enabled. When enabling them, there is an HTTP request for the serialised image which fails:

     Failure/Error: raise ActionController::RoutingError, "No route matches [#{env['REQUEST_METHOD']}] #{env['PATH_INFO'].inspect}"
     
     ActionController::RoutingError:
       No route matches [GET] "/__serialized__/_51p3niala.svg+xml"

Environment

  • Node version: v18.19.0 LTS
  • @percy/cli version: 1.28.5
  • Version of Percy SDK you’re using: percy-capybara
  • OS version: Debian Bookworm based Docker image (official ruby docker image)
  • Type of shell command-line [interface]: bash

Details

This error only occurs when we upgrade our Percy CLI from 1.27.4 to the latest 1.28.5. Much like #1568, 0a48e87 appears to be the culprit.

Unfortunately the fix for that issue (#1571) does not work as our Capybara drives Selenium in a different docker image, and so our host is not 127.0.0.1 or localhost but a 192.168. address.

@shantanuk-browserstack
Copy link
Contributor

Hi @ajoneil ,

Thank you for bringing this to our attention. Rest assured, we are currently investigating this.

Copy link

This issue is stale because it has been open for more than 14 days with no activity. Remove stale label or comment or this will be closed in 14 days.

@github-actions github-actions bot added the 🍞 stale Closed due to inactivity label May 21, 2024
Copy link

This issue was closed because it has been stalled for 28 days with no activity.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Jun 11, 2024
@Yama-Tomo
Copy link

Same issue. I think this rewrite needs to be configurable.

@Yama-Tomo
Copy link

@shantanuk-browserstack any update?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🍞 stale Closed due to inactivity
Projects
None yet
Development

No branches or pull requests

3 participants