Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PERCY_POSTINSTALL_BROWSER set to "0" or "false" should not trigger browser download #1687

Closed
wojtekmaj opened this issue Aug 8, 2024 · 2 comments
Labels
🐛 bug Something isn't working

Comments

@wojtekmaj
Copy link

The problem

Briefly describe the issue you are experiencing (or the feature you want to see
added to Percy). Tell us what you were trying to do and what happened
instead. Remember, this is not a place to ask questions. For that, go to
https://github.com/percy/cli/discussions/new

Environment

  • Node version:
  • @percy/cli version:
  • Version of Percy SDK you’re using:
  • If needed, a build or snapshot ID:
  • OS version:
  • Type of shell command-line [interface]:

Details

If necessary, describe the problem you have been experiencing in more detail.

Debug logs

If you are reporting a bug, always include logs! Give the "Debugging SDKs"
document a quick read for how to gather logs

Please do not trim or edit these logs, often times there are hints in the full
logs that help debug what is going on.

Code to reproduce issue

Given the nature of testing/environment bugs, it’s best to try and isolate the
issue in a reproducible repo. This will make it much easier for us to diagnose
and fix.

@ninadbstack
Copy link
Contributor

I have added a fix pr for this, would be merged and released in next CLI release

@ninadbstack ninadbstack added the 🐛 bug Something isn't working label Aug 20, 2024
@prklm10
Copy link
Contributor

prklm10 commented Sep 18, 2024

This was fixed in v1.29.3 . Closing this.

@prklm10 prklm10 closed this as completed Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants