Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shadow DOM no longer serialized in Chrome 131 (or in Chrome 130 in combination with Percy 1.30.4) #1819

Closed
mixonic opened this issue Dec 9, 2024 · 4 comments

Comments

@mixonic
Copy link

mixonic commented Dec 9, 2024

On a private codebase, we no longer see shadow DOM serialized into HTML for upload to Percy.

  • After adding Chrome 131 to our test suite, these elements never serialized.
  • After upgrading to Percy CLI 1.30.2-> 1.30.4 (in hopes it would address the issue), shadow DOM no longer serializes in Chrome 130 or 131.

The shadow root for our Web Components is open.

We're attempting to create a reproduction of this to support debugging, but wanted to open this ticket in case there are others in the Percy user community experiencing this issue.

However we can provide example before/after serialized HTML fragments:

Before:

<custom-toggle data-test-show-title-toggle="" class="mb-2.5 hydrated" checked="" data-percy-shadow-host="" data-percy-element-id="_fa3164h6n"><template shadowrootmode="open"><link rel="stylesheet" data-percy-adopted-stylesheets-serialized="true" href="https://HOSTNAME_REDACTED/__serialized__/_8oa38x04m.css"><label class="wrapper"><button class="toggle focus-visible:custom-form-el-focus toggled" aria-pressed="true" aria-labelledby="label"></button><span id="label" class="label-text"><slot name="label"></slot></span></label></template></custom-toggle>

After Chrome 131 (or Percy 1.30.4 and Chrome 130):

<custom-toggle data-test-show-title-toggle="" class="mb-2.5 hydrated" checked="" data-percy-shadow-host="" data-percy-element-id="_9zvgm69j8"></custom-toggle>
@pankaj443
Copy link
Contributor

Hey @mixonic thanks for reporting, we will be checking this. Please share a minimum reproducible unserialized HTML sample. Would be helpful in debugging.

@pankaj443
Copy link
Contributor

Hey @mixonic we have release CLI v1.30.5-beta.2 with fix for the issue. Please check

@eliasdawson-addepar
Copy link

Thanks @pankaj443 I can confirm on behalf of @mixonic that v1.30.5-beta.2 fixes the issue.

@pankaj443
Copy link
Contributor

Thanks, closing the issue as its resolved now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants